Repository navigation
Add failNextConnects: leave service discovery unanswered, then hang up - #31
Merged
Merged
Conversation
Reapplies #29, which was merged into ignore-next-messages after that branch had already been squash-merged into main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /command {"command": "failNextConnects", "value": N, "hangUpAfter": 7}makes the next N connects fail the way some pods do in loopandlearn/OmnipodKit#199:hangUpAfterseconds (default 7) withCBErrorDomaincode 7, "The specified device has disconnected from us."Only
-transport impossiblesupports it. For the app to see code 7 rather than a generic ImpossiBLE error, its ImpossiBLE needs mickeyl/ImpossiBLE#9.Testing:
go test ./pkg/bluetoothpasses.CBErrorDomain 7.Reapplies #29, which merged into
ignore-next-messagesafter that branch had already been squash-merged intomain(#28), so it never reachedmain. Same change;go test ./...passes on top of currentmain.