Repository navigation
Conversation
A reset fault reported the fault time, total delivered, bolus remaining and minutes since activation like any other fault, so OmnipodKit took it for a fault with a known time and never ran its reset handling. In 45 reset statuses from real pods (DASH, Omnipod 5 and Eros) the fault time is always zero ($FFFF on Eros), delivered and bolus not delivered are zero, and minutes active restarts at the reset. The simulator now reports those after a reset fault, while keeping its own delivery books, with the bolus stopped at the fault.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reset fault reported its fault time, total delivered, bolus remaining and minutes since activation like any other fault. OmnipodKit treats a fault that has a fault time as a non-reset fault, so testing a reset fault on the simulator ran the wrong path. For example, a 0x10 during a bolus reported fault time
0012, 2.75 U not delivered and 89 pulses delivered.What real pods report
45 reset-fault detailed statuses from field reports (0x10, 0x12, 0x22, 0x34, 0xD6 and 0xD7, from DASH, Omnipod 5 and Eros) all show:
0000(FFFFon Eros).0x3FFsigil.Change
SetFaultwith a reset code: records when the reset happened and sets the fault time to 0. A non-reset code, or clearing the fault, forgets the reset.The
0x3FFsigil for 0x22 isn't simulated, since real pods show it inconsistently.Testing
go test ./...passes, including two new state tests: a reset fault's marshaled status, and a non-reset fault keeping its time and counters.