Repository navigation
Conversation
|
@ayshadogo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Implement four Soroban contracts covering the assigned issues: - MindFlowInteractive#379 spending_limit: per-account daily and per-transaction caps, rolling daily spend tracking, delayed limit increases and immediate decreases - MindFlowInteractive#380 dispute_bond: bonds locked on report filing, admin/panel resolution, refund on upheld and forfeiture to treasury on rejected - MindFlowInteractive#381 token_streaming: accrual from ledger time, capped withdrawals, cancellation with remainder split, and recipient handoff - MindFlowInteractive#382 unlock_keys: admin/authorized minting, player-to-player transfers, burning and per-key-type supply tracking Closes MindFlowInteractive#379 Closes MindFlowInteractive#380 Closes MindFlowInteractive#381 Closes MindFlowInteractive#382
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds four Soroban contracts covering all open issues assigned to @ayshadogo. Each contract follows the repository's existing conventions:
#[contracttype]storage keys, typed#[contracterror]errors, event publishing and colocated unit tests.#379 - Spending Limit Module for Player Accounts
SpendingConfigwith daily and per-transaction caps.PendingLimitand only take effect after a configurable delay throughapply_pending.deposit/withdraw/spendflow rejects any transfer above either cap.#380 - Dispute Bond for Puzzle Reports
file_reportlocks a bond and opens a report withOpenstatus.Upheldrefunds the bond to the reporter;Rejectedforfeits it to the treasury.#381 - Token Streaming Payments
withdrawandwithdraw_allcan never exceed the accrued balance.cancelsplits the unstreamed remainder between sender and recipient using basis points, while already accrued funds remain withdrawable.change_recipient.#382 - Puzzle Unlock Keys
mintto players,transferbetween players andburnwhen a key is consumed.Test coverage
Unit tests were added for every contract: cap enforcement and daily reset, delayed increases and immediate decreases, bond refund/forfeit and single resolution, accrual math and withdrawal bounds, cancellation settlement, recipient handoff, key transfers and per-type supply. No builds, installs, CI or test commands were run locally, per the contribution instructions.
Closes #379
Closes #380
Closes #381
Closes #382