Skip to content

fix(circuit-breaker): restore green CI after #391 - #392

Merged
Mkalbani merged 1 commit into
MindFlowInteractive:mainfrom
Favouratambi:fix/369-circuit-breaker-ci
Nov 20, 2026
Merged

Mkalbani merged 1 commit into
MindFlowInteractive:mainfrom
Favouratambi:fix/369-circuit-breaker-ci

Conversation

@Favouratambi

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #369 / #391. The original PR was merged before its final CI fixes reached the branch, so main currently fails the Circuit breaker workflow. This PR applies exactly the validated fixes to the 3 affected test/source files:

  • Replaced two over-long symbol_short! literals (max 9 chars) with Symbol::new.
  • Borrowed proposal IDs in get_pause_proposal client calls.
  • Avoided moving Env before generating the integration-test user.
  • Removed unnecessary as u32 casts and used saturating_sub for the unpause countdown (required by clippy -D warnings).

No contract logic or public API changes.

Validation

The identical source tree passed on the fork's Ubuntu CI: cargo fmt --check, cargo test --locked (18 unit + 2 integration tests, all passing), cargo clippy --locked --all-targets -- -D warnings, and cargo build --locked --release --target wasm32v1-none.

Refs #369

@grantfox-oss

grantfox-oss Bot commented Nov 20, 2026

Copy link
Copy Markdown

Hey @Favouratambi 🦊, this PR isn't linked to an issue yet.

Add Closes #<issue> to the PR description, pointing at the issue this PR resolves.

Without it, your contribution can't be tracked on GrantFox and the issue won't close automatically when this PR is merged.

@Mkalbani

Mkalbani commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

@Favouratambi Alright good job

@Mkalbani
Mkalbani merged commit 6299379 into MindFlowInteractive:main Nov 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants