Repository navigation
Show climate parameters on the dimension biome map - #261
Merged
Merged
Conversation
The biome map now explains why a biome wins or never appears: - hovering (or a pinned point) lists the six climate values sampled there and, for multi-noise sources, the nearest entries best first, each with the parameters the climate is outside of; - Show switches the map to one climate parameter, or to Distance to win for a chosen biome (0 where it wins), with biome outlines kept on top; - Explain picks the biome to follow, and biomes listed in the source that win nowhere in view are named under the legend. The worker samples the climate once per cell and looks the entry up in a Deepslate Climate.Parameters that returns the entry index, so the map, the readout and the distance layer agree with the game's choice. Shared in packages/preview, so the web editor and VS Code both get it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AX3Tsy7i4uq6VDFLmVvUqF
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Brian · project thread
Makes it possible to see why a biome isn't showing up on a dimension's Biomes map. It's built in the shared
packages/preview, so the web editor and VS Code both get it.What changed
depthdepends on. For multi-noise sources it also lists the 4 nearest entries, best first, one per biome, with their distances. For each entry that lost, it names the parameters the climate falls outside of (e.g.humidity -0.300 ∉ 0.250…1.000).Climate.Parametersthat returns the entry's index, so the map, the readout and the distance layer all agree with the game's choice. The response now carries per-pixel climate planes, the winner's fitness and the packed entries. These are transferred, andlastis$state.raw.preview/climate.ts: fitness, nearest entries, the distance layer and the list of missing biomes.site/guides/editors.md(mcp docs synced), plus a line in the VS Code README.Sources that aren't multi-noise (fixed, checkerboard, the end) still get the climate readout and layers, but no entries.
Tests
a biome map shows the climate and explains which biome wins, run on cave-siege.svelte-checkpasses for preview, web and vscode.TestSiteSamplesandTestDocsInSyncpass.Generated by Claude Code