Repository navigation
Description
@antianqi We found the following issues while evaluating these two packages for the official plugin marketplace. We are tracking them together here and will review the packages again once they are fixed.
The review is based on community main at 0c20f90601b767c03f6d3693fdad4d9a82ac0923, with minimax-bot-team 1.0.0 and mmx-octopus 1.9.0. Tests used Node v22.23.4, installable packages exported according to the package contract, and a simulated Agent. No real model was used, and neither Electron behavior nor installation in the real host was tested.
1. minimax-bot-team: chat messages are cleared even when saving state fails
Steps to reproduce:
- Initialize
Storein a temporarydataDir, append a message to an existing chat, and save the original contents ofstate.json. - Replace that temporary
state.jsonfile with a directory of the same name, then callStore.deleteChat(chatId)so the state write fails withEISDIR. - The message file has already become
[]. Remove the directory, restore the original state file, and initialize a newStore.
Actual result: the chat is still listed, but it contains 0 messages. Under the same conditions, community minimax-bot 0.7.28 retains 2 messages after restart: the greeting and the appended message.
Team deletion implementation, L602–609 clears messages before calling save(). The minimax-bot implementation, L632–637 writes state first.
Please ensure that both the chat and its messages remain unchanged if the state write fails, and add tests for write failure and recovery after restart.
This test called Store.deleteChat directly, rather than clicking through the UI. Fault injection was limited to temporary test data.
2. mmx-octopus: cross-session awareness is on by default, and disabling it does not stop collection
Steps to reproduce:
- Start with a new data directory and use a simulated Host to record
observe,sessions, andruncalls. - Open
/dashboardwithout chatting.petAwaredefaults totrue, andobserve({all:true})andsessions()have already been called. There has been noruncall yet. - Send
{"enabled":false}toPOST /api/petaware, restart with the samedataDir, and open the page again.
Actual result: the setting is persisted as false, but those collection APIs are still called. With the default setting enabled, subsequent chats include other sessions' titles and statuses in model requests. Disabling the setting stops that prompt injection, but not collection. The probe did not find other sessions' message bodies in these requests.
Relevant source: default value, request-triggered collection, global subscription, and toggle controlling prompt inclusion.
Under this repository's review policy, privacy-sensitive cross-session features must be off by default and documented in the README. Please:
- Disable cross-session awareness by default and explain what information it reads and how that information is used.
- Stop the relevant cross-session subscriptions and reads when the toggle is off, rather than only excluding the information from prompts.
- Add tests covering first launch, toggling the setting, and restarting.
- Correct the minimum client version in the README from 3.1.5 to 3.1.6.
The old code that wrote to the host's agent directory has been confirmed removed in 1.9.0; it is not a blocker in this review.
We are holding off on official marketplace sync MRs for both packages until these issues are fixed and reviewed again.
Activity
[-]minimax-bot-team / mmx-octopus:同步官方市场前的数据丢失与感知开关问题[/-][+]minimax-bot-team / mmx-octopus: data loss and awareness toggle issues blocking official marketplace sync[/+]antianqi commentedon Nov 16, 2026
mmx-octopus 这半(第 2 条)已修完,PR #138:#138 —— CI 绿,可合并。
两条指控都属实,我们照单认领:
①
petAware的初值确实是true(state.mjs),新装即默认开着;② 关掉之后
observe({all:true})与sessions()确实照样被调 —— 开关当时只在buildStatusSummary()里挡住了「不写进提示词」,没挡住「采集」。改了什么(1.9.0 → 1.10.0)
petAware初值改成false,且只有明确传true才开(undefined与其它值一律按「关」处理)。已经装过的用户保留他自己上次的值。observe.mjs里订阅(scheduleObserve)、看板轮询(scheduleBoard)、换目标重订阅(restartObserve)三处加了同一个守卫;另加setAware():关掉时掐断订阅 + 停掉看板计时器 + 清掉已经显示出来的跨会话信息;服务端/api/petaware切换时调用它 —— 开关落到了采集层,不再只是挡提示词。怎么验的(判的是装配后的行为:真起一套 server + 模拟宿主,数 API 的调用次数,不是读源码字面量):
true才开;observe调 0 次、sessions()调 0 次;sessions())、看板里的跨会话信息被清空;observe.mjs的守卫 ⇒ 恰好 7 条红;把默认值注回true⇒ 恰好 9 条红;还原后文件与备份逐字一致。README 与清单
第 1 条(minimax-bot-team 删会话时写失败导致消息丢失)由同一位作者的另一个 PR 处理,完成后我把链接贴到这里。
antianqi commentedon Nov 16, 2026
Both packages in this report have their fix open, in two pull requests:
Point 1 - minimax-bot-team: chat messages are cleared even when saving state fails
You are right, and the fix follows the minimax-bot implementation you pointed at.
deleteChatcleared the transcript first and saved the state afterwards, so a failedstate write lost the messages for good. The state that no longer lists the chat now
goes to disk first, and the transcript is cleared only after that write succeeded:
A failed state write now leaves both the chat and its messages exactly as they were,
and the caller can try again.
The test travels with the package, so it can be run against the package itself:
It uses the same injection as the report -
state.jsonis replaced by a directory ofthe same name, so every write to it fails - and then checks that the messages are
still on disk, that the live state still knows the chat, and that after the state
file is restored and a new
Storeis initialized, the chat and its messages arestill there. A second test checks that a delete that succeeds still clears the
transcript and forgets the chat.
I falsified the test before shipping it: with the old order put back into the package
it fails with
the messages are still on disk(1 pass, 1 fail); with the fix itpasses 2/2.
Package version 1.0.1.
npm run validatereports 0 errors and 1 warning for thispackage (
ENTRY_STDOUTinminiapp/node/memory-bridge.mjs- the helper's own outputchannel, unchanged from 1.0.0) and
npm run checkpasses 92/92.Point 2 - mmx-octopus
That one is a different package and a different pull request (#138): cross-session
awareness is off by default, the toggle stops the subscriptions and the reads instead
of only excluding the data from the prompt, the README documents what it reads and
how the data is used, and the minimum client version is corrected to 3.1.6.
Thanks for the report - it was precise. Both halves are open for another look.
fix(minimax-bot-team): write the state that forgets a chat before its…
antianqi commentedon Nov 16, 2026
@MyPrototypeWhat — the
mmx-octopushalf is ready for another look (PR #138), and the tests you asked for are now shipped inside the package.They start a real server against a mock host and count the actual
observe/sessions()calls, so they check the assembled behaviour rather than the source text.Three cases are covered: first launch, toggling the setting, and restarting.
Two of them are negative injections — they break a copy of a production module and
assert that the criterion catches it. With the guard removed or the default flipped back
on, the test fails within seconds and names the broken assertions.
Also in that PR:
petAwarenow defaults to off; only an explicittrueturns it on.observesubscription is aborted, theboard polling timer is cleared, and the cross-session data already shown is wiped.
Previously only the prompt injection was gated; the APIs were still called.
1.10.0, and that the minimum client version is 3.1.6.
The
minimax-bot-teamhalf is handled in PR #139.fix(mmx-octopus): cross-session awareness is off by default and reall…