Repository navigation
fix(minimax-bot): 重试成功之后清掉那条未送达标记 - #147
Open
Apageoflove wants to merge 1 commit into
Open
Apageoflove wants to merge 1 commit into
Apageoflove wants to merge 1 commit into
Conversation
Apageoflove
force-pushed
the
fix/minimax-bot-retry-delivery
branch
2 times, most recently
from
November 20, 2026 01:20
0f14bcc to
c58898c
Compare
一条用户消息第一次投递失败时被标成 failed,页面显示「未送达」。用户点重试 成功后,回复来了,可原消息的 dispatchState 没人再改,永久停在 failed —— 于是聊天里一条已到的回复旁边挂着一条「未送达」。 retryMessage 的 run 闭包里补一步:回合被宿主接受后,把 message.sourceMessageId 指向的那条用户消息改成 delivered 并广播。只改仍带第一次失败判定的那些, 后来的操作写下的状态不动。 新测试在 0.7.28 上红、在切片上绿。全量 414 条通过。
Apageoflove
force-pushed
the
fix/minimax-bot-retry-delivery
branch
from
November 20, 2026 06:24
c58898c to
99d1f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一条消息投递失败,页面把它标成「未送达」。用户点重试,回复来了,可那条消息上的标记没人清,永久停在失败。于是聊天里一条已经到达的回复旁边,挂着一条写着没送出去的话。
retryMessage 原来只管跑重试那一回合,不回写原消息的投递状态。现在回合被宿主接受之后,顺着 message.sourceMessageId 找到那条用户消息,把它改成 delivered 并广播。只改仍然带着第一次失败判定的那些,later 的操作写过什么就不动。
复现拿真实 Engine 跑的:造一条 failed 的用户消息和一条带重试按钮的 bot 消息,调 retryMessage。在 0.7.28 上,重试产出了回复,用户消息还是 failed;改完之后变成 delivered。
测试加在 engine-reliability 里,在 0.7.28 上红、在切片上绿。全量 414 条过。
版本号到 0.7.33。0.7.29 到 0.7.32 被另外四条还开着的 PR 占着。
这个修复的前提是那种 bot 消息确实带着 sourceMessageId 指回用户那条。群聊里由别的 Bot 接力产生的回复不一定有,那种情况这次没处理,只改了直接回答的那一条。
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.