Repository navigation
fix(minimax-bot): 一轮里没人说话时不再把 [PASS] 当成结果 - #153
Open
Apageoflove wants to merge 1 commit into
Open
Apageoflove wants to merge 1 commit into
Apageoflove wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
群聊里成员没话说就回 [PASS],插件会把它标成跳过。但这一轮仍然被留成了最后一次发言的结果,所以讨论停在 [PASS] 上的时候,交给调用方的结论文本就是那三个字。
私有聊天里让 Bot 发一个群讨论任务,任务记录里的 result 就是 "[PASS]"。
更麻烦的是中间有人说过实质内容的情况。Alice 说了「@bob take a look」,Bob 回 [PASS],交出去的结论文本变成了 [PASS]。前面那位说的话被覆盖了,只剩聊天记录里还留着。
原因是 engine.mjs 的 driveGroup 里每跑完一轮就 lastResult = result,PASS 那一轮也不例外,然后 continue 往下走。收口那段文本只进了 noteRound,从来没进过返回值。
改法是让 PASS 那一轮不写 lastResult。跳过逻辑一个字没动,谁说话谁不说话都不变。全员 PASS 的轮次现在返回空文本,最后一个 PASS 的轮次保留前面真正说过的那句。
测试加在 engine-reliability 里两条。一条只有一个成员发言且只回 [PASS],断言返回的文本是空的,同时聊天里那条仍然标成 pass;一条 Alice 说话、Bob 回 [PASS],断言返回的是 Alice 那句。两条在 0.7.32 上都红,在切片上绿。全量 423 条过。
版本号到 0.7.37。0.7.33 到 0.7.36 被另外几条还开着的 PR 占着。
没验证的:真实 Host 和 Electron 没点过,只在 Node 22 上跑,Agent 是模拟的。
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.