Repository navigation
Place the ever and always forms of a member in its class - #278
Merged
estebanzimanyi merged 1 commit intoNov 19, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
estebanzimanyi
added a commit
that referenced
this pull request
Nov 19, 2026
MobilityDB supports one H3 release, H3_REQUIRED_VERSION of its top-level CMakeLists.txt, and its configure refuses any other; its .github/scripts/install-h3.sh builds that release from its tag. provision-meos installed libh3-dev, whichever release the PostgreSQL archive carries (4.5.0), so every libmeos build of the action stops at configure since MobilityDB pinned 4.6.0. The action takes H3 from the checkout's own script when the checkout carries it: it builds the release into a prefix cached by its version and installs it under /usr/local, where MobilityDB's CMake and the catalog parse find it, as GDAL is; a checkout predating the script takes the package as before. Witness: the tests job of MEOS-API #278 stops at "MobilityDB requires H3 4.6.0, but the header found at /usr/include/h3/h3api.h is H3 4.5.0" (run 44578447526), after installing libh3-1 4.5.0-1.pgdg26.04+1. Why: every consumer of provision-meos builds libmeos through it, MEOS-API's tests, GoMEOS, MobilityDuck's refresh and the JVM bindings among them.
MEOS writes the ever or always form of a member with its letter before the class token (eraster_value, the ever form of raster_value), and the object model assigns a function to a class by its prefix, so e<prefix> and a<prefix> matched no class and those functions belonged to none. #_candidates pairs each class prefix with its ever and always forms, and #_ever_always_ooname names such a member with its letter before the name of the plain form: Raster.eValue and Raster.aValue beside Raster.value, atValue and minusValue. Witness: test_the_ever_and_always_forms_of_a_member_stand_beside_it classifies eraster_value and araster_tile_value into Raster as eValue and aTileValue beside raster_value's value; it fails without the change. Measured: over the catalog derived from MobilityDB master 1f59b32c28 the object model of this branch and of master differ in twelve members alone, the ever and always forms of value, valueGdal, valueSeries, tileValue, tileValueArray and tileValueSeries joining Raster; every other key of the catalog is equal; the suite passes, 701 passed and 31 skipped. Why: the owner placed the five readers of a raster along a trajectory in one class, the letter of ever and always on the method name (2026-11-19, option A of the raster plan, MobilityDB #3775), and a binding projecting the object model then carries eRasterValue and aRasterValue.
estebanzimanyi
force-pushed
the
om/ever-always-of-a-class-prefix
branch
from
November 19, 2026 17:55
39f1bd3 to
3007001
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MEOS writes the ever or always form of a member with its letter before the class token (eraster_value, the ever form of raster_value), and the object model assigns a function to a class by its prefix, so e and a matched no class and those functions belonged to none. #_candidates pairs each class prefix with its ever and always forms, and #_ever_always_ooname names such a member with its letter before the name of the plain form: Raster.eValue and Raster.aValue beside Raster.value, atValue and minusValue.
Witness: test_the_ever_and_always_forms_of_a_member_stand_beside_it classifies eraster_value and araster_tile_value into Raster as eValue and aTileValue beside raster_value's value; it fails without the change.
Measured: over the catalog derived from MobilityDB master 1f59b32c28 the object model of this branch and of master differ in twelve members alone, the ever and always forms of value, valueGdal, valueSeries, tileValue, tileValueArray and tileValueSeries joining Raster; every other key of the catalog is equal; the suite passes, 701 passed and 31 skipped.
Why: the owner placed the five readers of a raster along a trajectory in one class, the letter of ever and always on the method name (2026-11-19, option A of the raster plan, MobilityDB #3775), and a binding projecting the object model then carries eRasterValue and aRasterValue.