Repository navigation
Regenerate on MobilityDB 78ebe3b7fe and read a value answered beside output arrays - #63
Merged
estebanzimanyi merged 1 commit intoNov 10, 2026
Conversation
…output arrays The function and object layers are generated from the MEOS-API catalog of MobilityDB 78ebe3b7fe. The bearing and the JSONB concatenations and containments state the order of their operands by name, without an invert argument; TJsonb.TjsonbContains and TjsonbContained are the containments of the values, beside the inherited time containment; Jsonb has TjsonbContains, TjsonbContained, TConcat and SetConcat, and Geo has Bearing from a point to a point or to a temporal point; the error codes of the SQL/JSON classes have their exceptions. tpoint_as_mvtgeom answers the geometry in the tile and writes the times of its points through an output array. tools/codegen.py (#_emit_outputs_wrapper) answers such a value first, `(IntPtr, long[])`, and null where MEOS answers NULL, as it answers null for a bool answering false; tools/objectgen.py (#map_tuple_return, #map_value_item) reads that first item as a value of its class, so TPoint.AsMVTGeom answers `(Geo?, long[])?`. OutputPointerTests calls it, and StringSizeTests and the example write a temporal value with temporal_out. Why: the layers were generated from MobilityDB 6f329a98d0, before the operand orders were named and before ttext_out and tfloat_out were removed, which the tests and the example called. The wrapper of a function answering a value beside output arrays answered the array alone, so the geometry of tpoint_as_mvtgeom, reshaped by MobilityDB #3525 to answer it, was dropped. Witness: over the same catalog, the generators before and after the change of codegen.py and objectgen.py differ in TpointAsMvtgeom and TPoint.AsMVTGeom alone, and the gap ledger keeps no row the change leaves. dotnet build reports 0 warnings and 0 errors, and dotnet test passes 99 of 99 against libmeos built from MobilityDB 78ebe3b7fe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function and object layers are generated from the MEOS-API catalog
of MobilityDB 78ebe3b7fe. The bearing and the JSONB concatenations and
containments state the order of their operands by name, without an
invert argument; TJsonb.TjsonbContains and TjsonbContained are the
containments of the values, beside the inherited time containment;
Jsonb has TjsonbContains, TjsonbContained, TConcat and SetConcat, and
Geo has Bearing from a point to a point or to a temporal point; the
error codes of the SQL/JSON classes have their exceptions.
tpoint_as_mvtgeom answers the geometry in the tile and writes the times
of its points through an output array. tools/codegen.py
(#_emit_outputs_wrapper) answers such a value first,
(IntPtr, long[]),and null where MEOS answers NULL, as it answers null for a bool
answering false; tools/objectgen.py (#map_tuple_return,
#map_value_item) reads that first item as a value of its class, so
TPoint.AsMVTGeom answers
(Geo?, long[])?. OutputPointerTests calls it,and StringSizeTests and the example write a temporal value with
temporal_out.
Why: the layers were generated from MobilityDB 6f329a98d0, before the
operand orders were named and before ttext_out and tfloat_out were
removed, which the tests and the example called. The wrapper of a
function answering a value beside output arrays answered the array
alone, so the geometry of tpoint_as_mvtgeom, reshaped by MobilityDB
#3525 to answer it, was dropped.
Witness: over the same catalog, the generators before and after the
change of codegen.py and objectgen.py differ in TpointAsMvtgeom and
TPoint.AsMVTGeom alone, and the gap ledger keeps no row the change
leaves. dotnet build reports 0 warnings and 0 errors, and dotnet test
passes 99 of 99 against libmeos built from MobilityDB 78ebe3b7fe.