Repository navigation
Name the hex text of a point cloud value by its portable format - #66
Merged
estebanzimanyi merged 1 commit intoNov 12, 2026
Merged
Conversation
The object layer gives no method the role names HexIn and HexOut: tools/objectgen.py reads the roles hexIn and hexOut, which the object model gives pcpoint_hex_in, pcpoint_hex_out, pcpatch_hex_in and pcpatch_hex_out, as it reads in and out, the roles #take_portable_names of GoMEOS's tools/objectgen.py reads. The catalog's typeEncodings names those four functions the text reader and writer of PCPoint and PCPatch, so PCPoint.FromText and PCPatch.FromText read the hex text and their AsText writes it through pcpoint_hex_out and pcpatch_hex_out, and ToString writes through AsText. Why. Rule 1 of the bindings in the input and output plan (MobilityDB #3353) names no reader or writer by its role, whoever owns the type; the rule of the object layer read the roles in and out alone, so the point cloud types kept HexIn and HexOut beside the portable names they duplicate. The tree is regenerated from the catalog of MobilityDB master 0bc5f54084, so it also carries the eight functions master adds, the ever and always overlaps of a temporal point cloud and a point cloud box in both orders, with their methods on TPCBox, TPCPatch and TPCPoint. Witness. On the catalog of MobilityDB master 0bc5f54084 and MEOS-API master cf4d124e6f, the generator before this change and this one differ in PCPoint.g.cs and PCPatch.g.cs alone, by those four methods, 5166 methods becoming 5162 over 155 classes, and two runs of this one write the same tree. Against the libmeos of that master with every family, dotnet build reports 0 warnings and 0 errors and dotnet test passes 106 of 106, none skipped; no test or example called HexIn or HexOut, and none reads a point cloud value, whose schema MEOS.NET has no fixture to register. MEOS.NET has no active committer: this needs another committer of the ecosystem to review and merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The object layer gives no method the role names HexIn and HexOut: tools/objectgen.py reads the roles hexIn and hexOut, which the object model gives pcpoint_hex_in, pcpoint_hex_out, pcpatch_hex_in and pcpatch_hex_out, as it reads in and out, the roles #take_portable_names of GoMEOS's tools/objectgen.py reads. The catalog's typeEncodings names those four functions the text reader and writer of PCPoint and PCPatch, so PCPoint.FromText and PCPatch.FromText read the hex text and their AsText writes it through pcpoint_hex_out and pcpatch_hex_out, and ToString writes through AsText.
Why. Rule 1 of the bindings in the input and output plan (MobilityDB #3353) names no reader or writer by its role, whoever owns the type; the rule of the object layer read the roles in and out alone, so the point cloud types kept HexIn and HexOut beside the portable names they duplicate.
The tree is regenerated from the catalog of MobilityDB master 0bc5f54084, so it also carries the eight functions master adds, the ever and always overlaps of a temporal point cloud and a point cloud box in both orders, with their methods on TPCBox, TPCPatch and TPCPoint.
Witness. On the catalog of MobilityDB master 0bc5f54084 and MEOS-API master cf4d124e6f, the generator before this change and this one differ in PCPoint.g.cs and PCPatch.g.cs alone, by those four methods, 5166 methods becoming 5162 over 155 classes, and two runs of this one write the same tree. Against the libmeos of that master with every family, dotnet build reports 0 warnings and 0 errors and dotnet test passes 106 of 106, none skipped; no test or example called HexIn or HexOut, and none reads a point cloud value, whose schema MEOS.NET has no fixture to register.
MEOS.NET has no active committer: this needs another committer of the ecosystem to review and merge it.