Repository navigation
Regenerate the functions and types layers from the catalog of MobilityDB master - #70
Merged
estebanzimanyi merged 1 commit intoNov 16, 2026
Conversation
…yDB master
tools/codegen.py and tools/objectgen.py over the catalog of MobilityDB
master af86409853 (MEOS-API ea8305118a). The types layer holds no
Numeric class and Jsonb no ToNumeric method: MEOS states
jsonb_to_numeric, numeric_in, numeric_out and the extract functions of
the time types internal, and the catalog gives numeric no class, numeric
being out of binding scope. The functions layer leaves pg_numeric.h,
which declares no public function, and gains the functions master adds
that merge consecutive spans and boxes into a number of them and the
spans and boxes of each instant, sequence and sequence set; the types
layer gains their methods. GAP-LEDGER.md records the extract functions
and jsonb_to_numeric as internal. PortableIoTests reads a JSON number as
its exact text and as a double, where it read a Numeric.
Witness. On main, objectgen defers Jsonb.toNumeric ("return
NumericData * needs wrapping") and Types/Numeric.g.cs declares a class
for it; with this commit objectgen defers no method and no Numeric class
exists, and Jsonb.FromText("12.50") answers "12.50" through AsText and
12.5 through ToFloat8.
Why. MEOS uses numeric only to read the numbers of JSON values, and
does so internally; a binding reads a JSON number natively or as its
decimal text, as a PostgreSQL client reads a numeric.
Measured against libmeos of MobilityDB master af86409853: objectgen
emits 154 classes and 5191 methods, 0 deferred; dotnet build
MEOS.NET.sln -c Release prints 0 warnings, 0 errors; dotnet test passes
117 tests, 0 failing, 0 skipped; the ExampleApp run exits 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/codegen.py and tools/objectgen.py over the catalog of MobilityDB
master af86409853 (MEOS-API ea8305118a). The types layer holds no
Numeric class and Jsonb no ToNumeric method: MEOS states
jsonb_to_numeric, numeric_in, numeric_out and the extract functions of
the time types internal, and the catalog gives numeric no class, numeric
being out of binding scope. The functions layer leaves pg_numeric.h,
which declares no public function, and gains the functions master adds
that merge consecutive spans and boxes into a number of them and the
spans and boxes of each instant, sequence and sequence set; the types
layer gains their methods. GAP-LEDGER.md records the extract functions
and jsonb_to_numeric as internal. PortableIoTests reads a JSON number as
its exact text and as a double, where it read a Numeric.
Witness. On main, objectgen defers Jsonb.toNumeric ("return
NumericData * needs wrapping") and Types/Numeric.g.cs declares a class
for it; with this commit objectgen defers no method and no Numeric class
exists, and Jsonb.FromText("12.50") answers "12.50" through AsText and
12.5 through ToFloat8.
Why. MEOS uses numeric only to read the numbers of JSON values, and
does so internally; a binding reads a JSON number natively or as its
decimal text, as a PostgreSQL client reads a numeric.
Measured against libmeos of MobilityDB master af86409853: objectgen
emits 154 classes and 5191 methods, 0 deferred; dotnet build
MEOS.NET.sln -c Release prints 0 warnings, 0 errors; dotnet test passes
117 tests, 0 failing, 0 skipped; the ExampleApp run exits 0.