Skip to content

Regenerate the functions and types layers from the catalog of MobilityDB master - #70

Merged
estebanzimanyi merged 1 commit into
MobilityDB:mainfrom
estebanzimanyi:regen/numeric-out-of-scope
Nov 16, 2026
Merged

estebanzimanyi merged 1 commit into
MobilityDB:mainfrom
estebanzimanyi:regen/numeric-out-of-scope

Conversation

@estebanzimanyi

Copy link
Copy Markdown
Member

tools/codegen.py and tools/objectgen.py over the catalog of MobilityDB
master af86409853 (MEOS-API ea8305118a). The types layer holds no
Numeric class and Jsonb no ToNumeric method: MEOS states
jsonb_to_numeric, numeric_in, numeric_out and the extract functions of
the time types internal, and the catalog gives numeric no class, numeric
being out of binding scope. The functions layer leaves pg_numeric.h,
which declares no public function, and gains the functions master adds
that merge consecutive spans and boxes into a number of them and the
spans and boxes of each instant, sequence and sequence set; the types
layer gains their methods. GAP-LEDGER.md records the extract functions
and jsonb_to_numeric as internal. PortableIoTests reads a JSON number as
its exact text and as a double, where it read a Numeric.

Witness. On main, objectgen defers Jsonb.toNumeric ("return
NumericData * needs wrapping") and Types/Numeric.g.cs declares a class
for it; with this commit objectgen defers no method and no Numeric class
exists, and Jsonb.FromText("12.50") answers "12.50" through AsText and
12.5 through ToFloat8.

Why. MEOS uses numeric only to read the numbers of JSON values, and
does so internally; a binding reads a JSON number natively or as its
decimal text, as a PostgreSQL client reads a numeric.

Measured against libmeos of MobilityDB master af86409853: objectgen
emits 154 classes and 5191 methods, 0 deferred; dotnet build
MEOS.NET.sln -c Release prints 0 warnings, 0 errors; dotnet test passes
117 tests, 0 failing, 0 skipped; the ExampleApp run exits 0.

…yDB master

tools/codegen.py and tools/objectgen.py over the catalog of MobilityDB
master af86409853 (MEOS-API ea8305118a). The types layer holds no
Numeric class and Jsonb no ToNumeric method: MEOS states
jsonb_to_numeric, numeric_in, numeric_out and the extract functions of
the time types internal, and the catalog gives numeric no class, numeric
being out of binding scope. The functions layer leaves pg_numeric.h,
which declares no public function, and gains the functions master adds
that merge consecutive spans and boxes into a number of them and the
spans and boxes of each instant, sequence and sequence set; the types
layer gains their methods. GAP-LEDGER.md records the extract functions
and jsonb_to_numeric as internal. PortableIoTests reads a JSON number as
its exact text and as a double, where it read a Numeric.

Witness. On main, objectgen defers Jsonb.toNumeric ("return
NumericData * needs wrapping") and Types/Numeric.g.cs declares a class
for it; with this commit objectgen defers no method and no Numeric class
exists, and Jsonb.FromText("12.50") answers "12.50" through AsText and
12.5 through ToFloat8.

Why. MEOS uses numeric only to read the numbers of JSON values, and
does so internally; a binding reads a JSON number natively or as its
decimal text, as a PostgreSQL client reads a numeric.

Measured against libmeos of MobilityDB master af86409853: objectgen
emits 154 classes and 5191 methods, 0 deferred; dotnet build
MEOS.NET.sln -c Release prints 0 warnings, 0 errors; dotnet test passes
117 tests, 0 failing, 0 skipped; the ExampleApp run exits 0.
@estebanzimanyi
estebanzimanyi merged commit acdce18 into MobilityDB:main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant