Repository navigation
Read every aggregate of the catalog as a static method of its values' class - #73
Merged
estebanzimanyi merged 1 commit intoNov 19, 2026
Conversation
… class The catalog's aggregates state, for each SQL aggregate, the MEOS functions of its transition and final steps. #aggregate_methods of tools/objectgen.py, built beside #method_for and calling its #map_param and #map_return, emits one static method per aggregate on the class of the value its transition takes after its state, as #aggregateMethods of MEOS.js's codegen/ObjectGenerator.ts does: the method takes the values as an array and the transition's other arguments, threads the transition over the values from a NULL state, as MEOS's C callers do, and answers the final function's result, the final function freeing the state. The method takes the name an engine holding one function per name calls the aggregate, its altSqlName or else its sqlName, in the PascalCase of every method: Raster.RasterUnion, Raster.SummaryStatsAgg and Raster.SameAlignmentAgg among the 27 emitted. An aggregate several transitions serve under one name over one class, as tMinAgg over the integer, float and text temporal values, takes no method, and GAP-LEDGER.md lists it under a kind of its own beside the two other reasons an aggregate stays out. MEOS.NET.Tests/AggregateTests.cs unions two tiles and states their statistics. Why: the object layer projected no aggregate, so a caller threaded RasterUnionTransfn and RasterUnionFinalfn by hand, and rasterUnion and summaryStatsAgg were the two raster functions MEOS.NET lacked. Measured: dotnet build reports 0 warnings and 0 errors, and dotnet test passes 120 of 120 with none skipped, against the libmeos of the catalog of MobilityDB master eb44541013.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catalog's aggregates state, for each SQL aggregate, the MEOS functions of its transition and final steps. #aggregate_methods of tools/objectgen.py, built beside #method_for and calling its #map_param and #map_return, emits one static method per aggregate on the class of the value its transition takes after its state, as #aggregateMethods of MEOS.js's codegen/ObjectGenerator.ts does: the method takes the values as an array and the transition's other arguments, threads the transition over the values from a NULL state, as MEOS's C callers do, and answers the final function's result, the final function freeing the state. The method takes the name an engine holding one function per name calls the aggregate, its altSqlName or else its sqlName, in the PascalCase of every method: Raster.RasterUnion, Raster.SummaryStatsAgg and Raster.SameAlignmentAgg among the 27 emitted. An aggregate several transitions serve under one name over one class, as tMinAgg over the integer, float and text temporal values, takes no method, and GAP-LEDGER.md lists it under a kind of its own beside the two other reasons an aggregate stays out. MEOS.NET.Tests/AggregateTests.cs unions two tiles and states their statistics.
Why: the object layer projected no aggregate, so a caller threaded RasterUnionTransfn and RasterUnionFinalfn by hand, and rasterUnion and summaryStatsAgg were the two raster functions MEOS.NET lacked.
Measured: dotnet build reports 0 warnings and 0 errors, and dotnet test passes 120 of 120 with none skipped, against the libmeos of the catalog of MobilityDB master eb44541013.