Repository navigation
State the units as the three-character branch of form holds them - #91
Merged
Merged
Conversation
The comments on the unit table and on conformantForm said the metre has no three-character spelling. The three-character branch of form holds UN/CEFACT Recommendation 20 common codes, as the standard's own examples write their units (KMH, MTR, MQS), and MTR is the metre. A register URI is the unambiguous spelling because it holds a ':', which no common code does. The comment of conformantForm sat above propForm, so it documented the wrong function; each comment now sits on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments only; no line of code changes.
tProps) and the one onconformantFormsay the metre has no three-character spelling. The three-character branch offormholds UN/CEFACT Recommendation 20 common codes, as the standard's own examples write their units (KMH,MTR,MQS), andMTRis the metre. A register URI is the unambiguous spelling because it holds a:, which no common code does; that is the reason the comments state.conformantFormsat abovepropForm, so it documented the wrong function.propFormsits above it, and each comment is on its own function.This matches the wiki page "Implementing OGC API — Moving Features in MobilityDB", issue 6 and resolution 3, which
ats_resolved_schema_test.goimplements.