Skip to content

State the units as the three-character branch of form holds them - #91

Merged
estebanzimanyi merged 1 commit into
masterfrom
docs/unit-comment-names-the-common-codes
Nov 19, 2026
Merged

estebanzimanyi merged 1 commit into
masterfrom
docs/unit-comment-names-the-common-codes

Conversation

@estebanzimanyi

Copy link
Copy Markdown
Member

Comments only; no line of code changes.

  • The comment on the unit table (tProps) and the one on conformantForm say the metre has no three-character spelling. The three-character branch of form holds UN/CEFACT Recommendation 20 common codes, as the standard's own examples write their units (KMH, MTR, MQS), and MTR is the metre. A register URI is the unambiguous spelling because it holds a :, which no common code does; that is the reason the comments state.
  • The comment of conformantForm sat above propForm, so it documented the wrong function. propForm sits above it, and each comment is on its own function.

This matches the wiki page "Implementing OGC API — Moving Features in MobilityDB", issue 6 and resolution 3, which ats_resolved_schema_test.go implements.

The comments on the unit table and on conformantForm said the metre has no
three-character spelling. The three-character branch of form holds UN/CEFACT
Recommendation 20 common codes, as the standard's own examples write their
units (KMH, MTR, MQS), and MTR is the metre. A register URI is the
unambiguous spelling because it holds a ':', which no common code does.

The comment of conformantForm sat above propForm, so it documented the wrong
function; each comment now sits on its own.
@estebanzimanyi
estebanzimanyi merged commit 02d8595 into master Nov 19, 2026
2 checks passed
@estebanzimanyi
estebanzimanyi deleted the docs/unit-comment-names-the-common-codes branch November 19, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant