Repository navigation
Regenerate the cell mixins from the catalog of MobilityDB master - #117
Merged
estebanzimanyi merged 1 commit intoNov 13, 2026
Merged
Conversation
pymeos/main/_generated/th3index_methods.py, tquadbin_methods.py and ts2cell_methods.py are the output of tools/oo_codegen/codegen.py over the catalog of MobilityDB master ab15a473fa: the MEOS Functions of the docstrings of at and minus of a temporal H3, QUADBIN and S2 cell name tcellindex_at_stbox and tcellindex_minus_stbox, which MobilityDB e976fc0f03 adds to the cell families; the dispatch of each method reads as before. Why. tests/test_oo_codegen_coverage.py BackingValidity.test_committed_matches_generator compares each committed mixin with the generator's output over the catalog CI derives from MobilityDB master, and fails for h3index, quadbin and s2cell on every pull request since that catalog holds tcellindex_at_stbox. Witness. Over the catalog of MobilityDB master ab15a473fa and MEOS-API master c13560a8a7, derived as CI derives it (provision-meos with the libmeos build, 5306 functions), tests/test_oo_codegen_coverage.py passes (4 tests, 18 subtests), the other six mixins regenerate unchanged, the suite passes (5080 tests), and ruff check and ruff format pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pymeos/main/_generated/th3index_methods.py, tquadbin_methods.py and ts2cell_methods.py are the output of tools/oo_codegen/codegen.py over the catalog of MobilityDB master ab15a473fa: the MEOS Functions of the docstrings of at and minus of a temporal H3, QUADBIN and S2 cell name tcellindex_at_stbox and tcellindex_minus_stbox, which MobilityDB e976fc0f03 adds to the cell families; the dispatch of each method reads as before.
Why. tests/test_oo_codegen_coverage.py BackingValidity.test_committed_matches_generator compares each committed mixin with the generator's output over the catalog CI derives from MobilityDB master, and fails for h3index, quadbin and s2cell on every pull request since that catalog holds tcellindex_at_stbox.
Witness. Over the catalog of MobilityDB master ab15a473fa and MEOS-API master c13560a8a7, derived as CI derives it (provision-meos with the libmeos build, 5306 functions), tests/test_oo_codegen_coverage.py passes (4 tests, 18 subtests), the other six mixins regenerate unchanged, the suite passes (5080 tests), and ruff check and ruff format pass.