Skip to content

Regenerate the cell mixins from the catalog of MobilityDB master - #117

Merged
estebanzimanyi merged 1 commit into
MobilityDB:masterfrom
estebanzimanyi:tooling/regen-cell-mixins
Nov 13, 2026
Merged

estebanzimanyi merged 1 commit into
MobilityDB:masterfrom
estebanzimanyi:tooling/regen-cell-mixins

Conversation

@estebanzimanyi

Copy link
Copy Markdown
Member

pymeos/main/_generated/th3index_methods.py, tquadbin_methods.py and ts2cell_methods.py are the output of tools/oo_codegen/codegen.py over the catalog of MobilityDB master ab15a473fa: the MEOS Functions of the docstrings of at and minus of a temporal H3, QUADBIN and S2 cell name tcellindex_at_stbox and tcellindex_minus_stbox, which MobilityDB e976fc0f03 adds to the cell families; the dispatch of each method reads as before.

Why. tests/test_oo_codegen_coverage.py BackingValidity.test_committed_matches_generator compares each committed mixin with the generator's output over the catalog CI derives from MobilityDB master, and fails for h3index, quadbin and s2cell on every pull request since that catalog holds tcellindex_at_stbox.

Witness. Over the catalog of MobilityDB master ab15a473fa and MEOS-API master c13560a8a7, derived as CI derives it (provision-meos with the libmeos build, 5306 functions), tests/test_oo_codegen_coverage.py passes (4 tests, 18 subtests), the other six mixins regenerate unchanged, the suite passes (5080 tests), and ruff check and ruff format pass.

pymeos/main/_generated/th3index_methods.py, tquadbin_methods.py and ts2cell_methods.py are the output of tools/oo_codegen/codegen.py over the catalog of MobilityDB master ab15a473fa: the MEOS Functions of the docstrings of at and minus of a temporal H3, QUADBIN and S2 cell name tcellindex_at_stbox and tcellindex_minus_stbox, which MobilityDB e976fc0f03 adds to the cell families; the dispatch of each method reads as before.

Why. tests/test_oo_codegen_coverage.py BackingValidity.test_committed_matches_generator compares each committed mixin with the generator's output over the catalog CI derives from MobilityDB master, and fails for h3index, quadbin and s2cell on every pull request since that catalog holds tcellindex_at_stbox.

Witness. Over the catalog of MobilityDB master ab15a473fa and MEOS-API master c13560a8a7, derived as CI derives it (provision-meos with the libmeos build, 5306 functions), tests/test_oo_codegen_coverage.py passes (4 tests, 18 subtests), the other six mixins regenerate unchanged, the suite passes (5080 tests), and ruff check and ruff format pass.
@estebanzimanyi
estebanzimanyi merged commit a3f5153 into MobilityDB:master Nov 13, 2026
8 checks passed
@estebanzimanyi
estebanzimanyi deleted the tooling/regen-cell-mixins branch November 13, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant