Skip to content

Export ObjectivePkg at top level so MSPackageManager can find it - #173

Merged
Fxe merged 1 commit into
ModelSEED:devfrom
cshenry:fix/export-objectivepkg
Nov 18, 2026
Merged

Fxe merged 1 commit into
ModelSEED:devfrom
cshenry:fix/export-objectivepkg

Conversation

@cshenry

@cshenry cshenry commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Problem

MSPackageManager discovers packages from the top-level modelseedpy namespace (inspect.getmembers(sys.modules["modelseedpy"]), fbapkg/mspackagemanager.py). ObjectivePkg is exported from modelseedpy.fbapkg but is missing from the top-level import list in modelseedpy/__init__.py. So on dev:

model.pkgmgr.getpkg("ObjectivePkg")
# PackageError: Package ObjectivePkg does not exist!

This breaks every caller that sets an objective through the package manager. For example, KBUtilLib's MSFBAUtils.set_objective_from_string and run_fva silently produced zero FVA rows against dev. The released 0.4.2 line exports it, so this is a regression on dev.

Fix

  • Add ObjectivePkg to the top-level from modelseedpy.fbapkg import (...) list.
  • Add tests/fbapkg/test_package_manager_exports.py, which asserts that every concrete *Pkg class exported by modelseedpy.fbapkg is also exported at top level, and that ObjectivePkg appears in MSPackageManager.list_available_packages().

Verification

  • New tests: 2 passed with the fix, 2 failed with it reverted.
  • tests/fbapkg: 26 passed with the fix. Without it, the 24 pre-existing tests pass and the 2 new ones fail.
  • MSPackageManager.get_pkg_mgr(e_coli_core).getpkg("ObjectivePkg") returns an ObjectivePkg.

🤖 Generated with Claude Code

MSPackageManager discovers packages from the top-level modelseedpy
namespace (inspect.getmembers(sys.modules["modelseedpy"])). ObjectivePkg is
exported from modelseedpy.fbapkg but was missing from the top-level import
list, so model.pkgmgr.getpkg("ObjectivePkg") raised
PackageError("Package ObjectivePkg does not exist!"). That breaks every
caller that sets an objective through the package manager, e.g. KBUtilLib's
MSFBAUtils.set_objective_from_string and run_fva.

Adds ObjectivePkg to the top-level fbapkg import, and a regression test that
every concrete *Pkg class exported by modelseedpy.fbapkg is also exported at
top level and that ObjectivePkg is listed by MSPackageManager.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Fxe

Fxe commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

looks like simple styling complain will fix later. PR approved

@Fxe
Fxe merged commit 67e8284 into ModelSEED:dev Nov 18, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants