Repository navigation
Conversation
Interactive mockups of the calm workbench redesign (rounds 1 to 3, one artboard per tab plus a new Sessions tab), the shared run-context picker snippets, a local viewer that renders the artboards without the cloud canvas, and the implementation contract (tokens, glyph vocabulary, shell, picker and clipboard behaviour, shared parts, page mappings, accessibility contract, evidence). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Top-tab shell with a shared run-context picker (grouped, searchable run list; Ctrl+C over a run copies its id, Ctrl+V over the chip views it), design tokens with bundled fonts, themed scrollbars and focus rings, and fifteen shared parts (status glyph vocabulary, dimension line, panels, grouped lists, segmented controls, chips, log lines, error cards, two-step buttons, empty states). Every tab is rebuilt on its existing projection services: Scheduler (one run-list owner, grouped inbox list, progressive filters, two-step cancel), Diagnostics (run facts, filterable event log, explained error card, deep link kept), I/O Inspector (node and port tree, one artifact card, saved workflow inspection kept; fixes the pre-existing a11y and append/remove findings), Network (local node and peers, honest degraded text), Graph (Edit workflow and As run modes; run mode is the isolated read-only run graph per ADR-014), Node Editor (built-in definitions read-only with authoring controls disabled at the boundary), Library (usage-joined model list, Hugging Face search mode, two-step delete), and a new Sessions tab over saved workflows and orchestrations. Settings and its embedded panels and the graph node, edge and minimap components are restyled without behaviour change. Also: PumasHfModelSearchResult now mirrors its producer (Pumas HuggingFaceModel, camelCase); the Settings retention deep link targets the retention form; a Library delete confirmation no longer carries over to a different model; the last !important style overrides are removed. Plan: docs/plans/workbench-redesign/plan.md (ADR-014). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Artifacts are selected from the node and port tree before their card is checked; the stream button, Refresh and error regions use the new test ids; the stale-read check waits for the read to start before removing the artifact. Assertion intent is unchanged. The fixture harness passed on real WebKitGTK (see the plan's evidence folder). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Plan package following the Coding-Standards template: objective and acceptance claims (A1 to A4 satisfied in a representative environment, A5 pending the owner's desktop run), binding decisions, the Standards Engine route snapshot, milestones M0 to M9 with their write sets, the execution ledger, 64 dispositioned issues (mostly projection fields the mockups assumed), per-milestone reports, the walkthrough tooling and fixtures, and the closing screenshots and WebKitGTK harness log. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…or re-plan after PR #95 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…edesign Merges codex/pantograph-rpc-workflow-2026-09-26 at cc6b6c4 (the RPC branch merged with origin/main at 46aad58) into feat/workbench-redesign. Rule: the redesign (ours) keeps structure and presentation; every behavioural change from the incoming side is re-applied on top of it. Conflicted files and resolutions: - docs/plans/README.md: kept every row from both sides, namely the merge note, the CPU scheduler row, the main and RPC-branch rows for each plan, and the Workbench redesign row (placed after the RPC-branch domain row). - src/components/WorkflowToolbar.svelte: redesign toolbar plus typed submit inputs (workflowSubmitInputs), the desktop seed checks (desktopSeedInputError in the disabled reason, assertDesktopSeedInputs before submit), post-submit output and node-status overlays fenced on the submitted graph revision, and the run-projection and validation-subscription error notes, restyled as wt-note alerts. - src/components/edges/ReconnectableEdge.svelte: kept ours. The incoming change drops the glow filter from axis-aligned paths; the redesigned neutral wire has no gradient or filter, so the fix has nothing to apply to. - src/components/nodes/workflow/ImageOutputNode.svelte: redesign tokens plus the artifact-reference decode (decodeImageArtifactReference and readImageArtifact), object-URL lifecycle fenced on the effect, decode-failure error, loading text, capture-phase control events and the dialog label. - src/components/nodes/workflow/NumberInputNode.svelte: redesign tokens plus seed-input detection, numberInputState/PersistedValue/DisplayValue, seed bounds and the aria-invalid inline error. - src/components/nodes/workflow/PumaLibNode.svelte: kept ours; it already derives modelId from data.model_id, which is the incoming change. - src/components/nodes/workflow/TextOutputNode.svelte: redesign tokens plus the "Empty text output" branch for a successful empty string, the 360px bounded node width and overflow-wrap. - src/components/server-status/ExternalConnectionPanel.svelte: redesign fields plus the canConnect prop gating both inputs and Connect. - src/components/workbench/IoInspectorPage.svelte: redesign page and its declarative download anchor (startBrowserDownload) kept; re-applied the page-lifecycle fence on every await of downloadArtifactBody. The complete-image guard assertCompleteIoArtifactImageRead and the data-preview-complete/byte-length attributes were already on ours. The incoming artifactDownloadLifecycle queue is not adopted (the redesign's anchor owns that job); the video caption notice has no target because the redesign renders video as a binary preview with Download. - src/components/workbench/LibraryPage.svelte: redesign page plus browser host capability loading and the search/write gating (browserLibraryActionAllowed) on every action, its block reasons, and the library-host-notice text. - src/components/workbench/RunGraphSnapshot.svelte: kept ours. The incoming change annotates a role=button <g>; the redesign uses real <button> elements, so there is no a11y ignore to annotate. - src/components/workbench/WorkbenchShell.svelte: redesign shell plus the "Loopback browser host" chip from getWorkflowBrowserHost. - src/components/workbench/ioInspectorPresenters.test.ts: ours (which already carries the two assertCompleteIoArtifactImageRead tests) plus the incoming video caption-notice test. Auto-merged files checked: package.json and package-lock.json (main's dependency bumps, commonmark and the role-button lint test plus the redesign fonts; the lock root matches package.json), DeviceConfig.svelte (lifecycle fencing), ServerStatus.svelte (configReady and canConnect), DependencyEnvironmentNode.svelte (runtime-only activity log, browser-host guard) and ioInspectorPresenters.ts (captionNotice). No incoming file references a presenter export the redesign removed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The evidence drivers and page fixtures under docs/plans/**/reports/tools run under Node and inside a browser; the flat config had no environment for them, so the staged-file lint rule failed on globals. Two fixtures also carried an unused destructuring and a redundant global comment. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The redesigned I/O Inspector owns its download anchor and URL release through createIoArtifactDownloadUrlOwner, so artifactDownloadLifecycle.ts and its test no longer have an importer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Adds the 2026-11-03 ledger entry for merge 9fbdda3 (parents 002b27a and cc6b6c4): the thirteen conflicted files and how each was resolved, the auto-merged files checked, the two follow-up commits, and the gate, walkthrough and WebKitGTK harness results, including the harness's 20 s readiness budget finding. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… ready The I/O Inspector WebKit harness waited 20 s for the fixture page; after the main merge Vite re-optimises the dependency graph on every start and readiness took 26 s, so the harness failed before the page existed. The wait is now 90 s. Verified: PASS on real WebKitGTK after the merge. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…design Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ench redesign Merges origin/feat/nodelab-trusted-catalog (PR #95, "author pinned host-admitted workflows"; six commits on top of main at 46aad58, which this branch already contains). Conflicts and resolutions: - src/components/workbench/NodeLabPage.svelte: both sides rewrote the page. Took the incoming (#95) version as the functional base: it drives the admitted-node catalog, workflow draft, Apply input, Save workflow, Refresh catalog, Reopen saved workflow and session cleanup retry through nodeLabController.ts and customNodeAuthoring.ts. The redesign's M6 version only mocked those as disabled controls; M6b re-projects #95's page into the redesign layout in the next commit. - src/components/workbench/nodeLabPresenters.ts: took #95's version for the same reason (its presenters back the real page). - src/components/workbench/nodeLabPresenters.test.ts: took #95's version so its presenter tests run against its presenters. Auto-merged without conflict: docs/plans/domain-architecture-and-multimodal/ {plan,execution-ledger,issues}.md, docs/custom-nodes.md, src-tauri/src/app_setup.rs and the remaining #95 files. Verified on the merge result: npm run typecheck passes; npm run test:frontend passes 871 tests, including nodeLabPresenters.test.ts and customNodeAuthoring.test.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…roller M6b (resolves WR-066). Re-projects PR #95's NodeLab page into the redesign's three panels without changing what it does; the controller (nodeLabController.ts) and service (customNodeAuthoring.ts) are untouched. - Dimension line summarises the catalog and draft state; the trust message stays as the in-place notice. - Left: admitted nodes as ListRows (glyph, type, ports, description, "in draft" marker), Refresh catalog, search for 6 or more nodes, and Create {label} draft for the selected node. - Centre: Reopen saved workflow, the draft header with its saved path, text inputs with Apply input, outputs, and Save workflow; the empty catalog is the EmptyState. - Right: canvas preview, contract checks, implementation identity, session cleanup with retry, and authoring status rows. - Errors render muted, in the panel of the control that raised them. - Board items #95 has no counterpart for (New node, Save draft, Publish, Try with sample inputs, editable definition fields) are omitted. Presenter tests: #95's test kept, nine added for the new projections. Adds the walkthrough fixture fixture-node-authoring.js, the M6b report, WR-066's disposition and the plan's Blockers line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MrScripty
added a commit
that referenced
this pull request
Nov 5, 2026
feat(workbench): replace the workbench GUI with the calm redesign # Conflicts: # docs/plans/README.md
Owner
Author
|
Merged into main as merge commit 17d5a4e ("Merge pull request #99 from MrScripty/feat/workbench-redesign") together with #95, #92 and #98 in one push, per the owner's request for a single combined CI run. GitHub did not record the merge automatically because this PR was retargeted from the RPC branch to main after the push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the workbench GUI with the calm redesign specified in
docs/design/workbench-redesign-spec.md. Four commits on the branch's real history: the design docs and mockups, the source change, the I/O Inspector e2e harness port, and the plan package with reports and evidence.User-visible outcome:
!importantstyle overrides removed; bundled fonts (SIL OFL).Defects fixed on the way: a Library delete confirmation could carry over to a different model; the Settings retention deep link landed one section early;
PumasHfModelSearchResultdid not match its producer (PumasHuggingFaceModel, camelCase); pre-existing a11y and append/remove findings in the I/O Inspector.Where the mockups assumed facts the backend does not expose yet, pages show muted text or disabled controls with a title; nothing is invented. Each gap is an issue row with a revisit trigger.
Review decisions requested: WR-024 (inline video preview dropped in favour of Download, since the 64 KiB preview cap meant playback was only ever partial) and WR-011 (Scheduler filters client-side over the 250 newest runs).
Status: draft until the base branch has merged
origin/main; that merge will then be merged into this branch (twelve frontend files are known to conflict with fixes main gained since September; resolutions are worked out) and the gates re-run here.Selected Evidence
docs/plans/workbench-redesign/plan.md(acceptance table, binding decisions, Standards Engine route snapshotsnapshot:v1:58a8cb6f-8bc1-4f8b-9f84-caa364b3df2b),execution-ledger.md,issues.md(64 dispositioned rows), per-milestone reports underreports/.docs/design/workbench-redesign-spec.md; ADR-014.@fontsource/newsreader,@fontsource/atkinson-hyperlegible,@fontsource/jetbrains-mono5.3.0 (SIL OFL 1.1), recorded in the ledger.Verification
reports/evidence/01…14*.pngreports/evidence/webkit-io-inspector-harness.log)npm run test:frontend688 passing--max-warnings 0on every changed file, vite buildnpm run dev:desktop, then the harness commands inreports/m9-e2e-harnesses.md)🤖 Generated with Claude Code