Repository navigation
test(importer): give the custody guard stage-proof worker a 30s liveness bound - #117
Merged
Merged
Conversation
…ess bound custody_guard_hf_stage_proofs_preserve_followers_and_refuse_stale_use runs a chain of real durable acquisition-store updates, metadata writes and finalize attempts inside one worker, bounded by a 5s timeout. It takes about 0.6s on Linux, but Windows CI runners intermittently exceed 5s and fail with Elapsed(()) (#109 and #113 runs on 2026-11-06). The timeout only guards against a hung worker, so raise it to 30s. All custody, stale-proof and follower assertions are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Contributor
[Low impact] This PR appears safe to merge. SummaryRaises one importer test’s worker timeout from 5 to 30 seconds to allow slower Windows disk writes.
Reviews (1) · Last reviewed commit: "test(importer): give the custody guard s..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an intermittent Windows CI failure that hit #109 and #113 today:
Cause
The test's worker runs a chain of real durable work inside one 5 s
tokio::time::timeout: acquisition-store updates,metadata.jsonreads and writes, and fourfinalize_downloaded_directory_with_capabilityattempts. It finishes in about 0.6 s on Linux, but Windows CI file systems sometimes push it past 5 s.Fix
Raise the bound to 30 s. The timeout only exists to catch a hung worker; it doesn't assert performance. The custody, stale-proof, hidden-follower and settlement assertions are unchanged.
Verification
cargo test --offline --locked -p pumas-library --lib custody_guard_hf_stage_proofspasses (0.59 s).cargo fmt --checkis clean.🤖 Generated with Claude Code