Skip to content

test(importer): give the custody guard stage-proof worker a 30s liveness bound - #117

Merged
MrScripty merged 1 commit into
mainfrom
test/custody-guard-liveness-bound
Nov 6, 2026
Merged

MrScripty merged 1 commit into
mainfrom
test/custody-guard-liveness-bound

Conversation

@MrScripty

Copy link
Copy Markdown
Owner

Fixes an intermittent Windows CI failure that hit #109 and #113 today:

model_library::importer::tests::custody_guard_hf_stage_proofs_preserve_followers_and_refuse_stale_use
panicked at crates\pumas-core\src\model_library\importer.rs:2593:14:
called `Result::unwrap()` on an `Err` value: Elapsed(())

Cause

The test's worker runs a chain of real durable work inside one 5 s tokio::time::timeout: acquisition-store updates, metadata.json reads and writes, and four finalize_downloaded_directory_with_capability attempts. It finishes in about 0.6 s on Linux, but Windows CI file systems sometimes push it past 5 s.

Fix

Raise the bound to 30 s. The timeout only exists to catch a hung worker; it doesn't assert performance. The custody, stale-proof, hidden-follower and settlement assertions are unchanged.

Verification

  • cargo test --offline --locked -p pumas-library --lib custody_guard_hf_stage_proofs passes (0.59 s).
  • cargo fmt --check is clean.

🤖 Generated with Claude Code

…ess bound

custody_guard_hf_stage_proofs_preserve_followers_and_refuse_stale_use
runs a chain of real durable acquisition-store updates, metadata writes
and finalize attempts inside one worker, bounded by a 5s timeout. It
takes about 0.6s on Linux, but Windows CI runners intermittently exceed
5s and fail with Elapsed(()) (#109 and #113 runs on 2026-11-06).

The timeout only guards against a hung worker, so raise it to 30s. All
custody, stale-proof and follower assertions are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c3ad4aea-d6af-4036-9d62-981fc937c480
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Raises one importer test’s worker timeout from 5 to 30 seconds to allow slower Windows disk writes.

  • The custody-guard test waits longer for its worker to finish.

Reviews (1) · Last reviewed commit: "test(importer): give the custody guard s..." · Reviewed by Greptile

@MrScripty
MrScripty merged commit 58ff157 into main Nov 6, 2026
35 checks passed
@MrScripty
MrScripty deleted the test/custody-guard-liveness-bound branch November 6, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant