Repository navigation
fix(import): keep import publication out of the watcher; ignore atomic staging siblings - #158
Merged
Merged
Conversation
…c staging siblings Import publication now records its destination with the owned-move watcher suppression before renaming into place, so the watcher (natively recursive on Windows) no longer triggers a full reclassification that races the import's own finalization. Payload proof also skips exactly the <document>.<uuid>.<attempt>.tmp sibling of an atomic root-document replacement; lookalikes, payload staging names and directories are still refused. Fixes the intermittent Windows 'download recovery path is outside its verified filesystem authority' failures in the acquired_* tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the intermittent Windows failures in
acquired_gguf_vision::moved_primary_requires_current_acknowledgement_and_owned_file_bindingsandacquired_model_bridge::safetensors_single_file_is_genuine_and_receipt_bound("download recovery path is outside its verified filesystem authority").Root cause: import publication renamed its stage into place without the owned-move watcher suppression that merge and migration use. Windows directory notifications are recursive, so the watcher saw the publication as an external change. It then ran a full reclassification right after the import released the root. That pass atomically rewrote
metadata.json, and the briefmetadata.json.<uuid>.<n>.tmpsibling showed up as an unbound entry in the payload proof.importer/staging.rs: callnotify_owned_move_destinationbefore publishing. Two notifier-count tests were updated (2 → 3 calls).import_custody.rs/metadata/atomic.rs: payload observation skips only<root document>.<uuid>.<u8>.tmpregular files at the model root, including ones that have already vanished. Lookalikes, staging-style names of payload files, out-of-range attempts and directories are still refused. A new unit test covers each case.Verification
fix/windows-recovery-authority, the Windows Rust release job was green, and 8 Windows stress iterations of the acquired_* tests were all green.pumas-librarysuite, clippy-D warnings, and the Windows cross-check all pass.🤖 Generated with Claude Code