Repository navigation
Conversation
…uests Anonymous GitHub API requests from shared CI runners hit the 60/hour limit while listing ONNX Runtime releases, failing the packaged-ONNX verifiers. Pumas now reads an optional PUMAS_GITHUB_TOKEN and sends it as a bearer token only to the real GitHub API origin; loopback fixtures and other hosts never receive it, Debug output redacts it, and the child-process allowlist keeps it out of runtimes. The ONNX verifiers pass it through their sanitized environment, and CI supplies the job's short-lived github.token, so no credential lives in the repo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The packaged-ONNX verifiers in CI kept failing with "GitHub rate-limited the ONNX Runtime release listing". This happened on main at 5175306 and on the v0.8.0 macOS headless build. Pumas listed releases anonymously from shared runner IPs, which hit GitHub's limit of 60 requests per hour.
network/github.rs): reads an optionalPUMAS_GITHUB_TOKENand sendsAuthorization: Bearer …only when the client targets the realhttps://api.github.comorigin.Debugoutput is redacted.child_environmentis an allowlist, so the token never reaches runtimes. A test now names it explicitly.packaged_onnx_support.child_environmentpasses through onlyPUMAS_GITHUB_TOKEN.GITHUB_TOKEN,HF_TOKENand similar are still dropped, and a Python test covers this.PUMAS_GITHUB_TOKEN: ${{ github.token }}. That is the job's short-lived token, so no credential is committed.Verification
network::githubtests pass (25, including 2 new). Thechild_environmenttests andtest_inference_release(with 1 new test) also pass.-D warnings, ruff format and both attribution checks pass.🤖 Generated with Claude Code