Skip to content

Bug/sr ndsp 717 empty entity casting #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgeRobertson merged 3 commits into from
Nov 4, 2026
Merged

Bug/sr ndsp 717 empty entity casting #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcd82da
fix: ensure empty entities have schema applied in duckdb contract app…
stevenhsd Oct 29, 2026
2cab0aa
fix: exit business rules if processing fails ahead of orphan and grou…
stevenhsd Oct 30, 2026
57cb352
style: linting fixes
stevenhsd Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dve/core_engine/backends/implementations/duckdb/contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def apply_data_contract(
if relation_is_empty(relation):
self.logger.warning(f"+ Empty relation for {entity_name}")
empty_df = pl.DataFrame([], schema=polars_schema) # type: ignore # pylint: disable=W0612
relation = self._connection.sql("select * from empty_df")
entities[entity_name] = self._connection.sql("select * from empty_df")
continue

self.logger.info(f"+ Applying contract to: {entity_name}")
Expand Down
1 change: 1 addition & 0 deletions src/dve/pipeline/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,7 @@ def apply_business_rules( # pylint: disable=R0914,R0915
submission_status.validation_failed = True
elif not rules_success:
submission_status.processing_failed = True
return submission_info, submission_status

for entity_name, entity in entity_manager.entities.items():
# Note BI filtering done within the apply_rules
Expand Down
Loading