Skip to content

chore(sdk/go)!: remove the Go SDK, now at github.com/ai-openshell/sdk-go - #5461

Open
rhuss wants to merge 2 commits into
NVIDIA:mainfrom
rhuss:chore/5242-remove-go-sdk/rhuss
Open

rhuss wants to merge 2 commits into
NVIDIA:mainfrom
rhuss:chore/5242-remove-go-sdk/rhuss

Conversation

@rhuss

@rhuss rhuss commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Summary

The Go SDK moved to ai-openshell/sdk-go, and the v0.1.8 release created the final sdk/go/v0.1.8 tag with the deprecation notice. This removes what is left of the in-tree SDK, together with the Go tagging path in the release workflow.

Related Issue

Closes #5242
Part of #5031

Changes

  • Remove sdk/go/, tasks/go.toml, and the Go toolchain and tools from mise.toml and mise.lock. Nothing else in this repository is written in Go.
  • Release: delete sdk-go-tag.yml and the tag-sdk-go job in release-publish.yml, including its needs entry and the expected-publisher check.
  • Branch Checks: drop the Go SDK Freeze job, which has nothing left to guard.
  • CodeQL: drop the Go language entry, its setup and build steps, and sdk/go in the CodeQL config.
  • Compatibility review: drop the go-sdk surface from the review prompt and from the validator, which rejects reviews that don't cover exactly the listed surfaces.
  • Docs: docs/sdk/go.mdx now describes github.com/ai-openshell/sdk-go (Go 1.26 or later, SDK version matching the gateway) and keeps the migration steps reviewed on chore(sdk/go): deprecate the in-tree Go SDK and drop its CI gate #5245. README, CONTRIBUTING, AGENTS, TESTING, CI.md, buf.yaml, and the Windows skill drop or redirect their sdk/go references.
  • Kept on purpose: the existing sdk/go/vX.Y.Z tags, so builds that use the old module path keep working; the docs nav entry; and the pyproject.toml comment about sdk/go/v* tags.

Release Notes

The Go SDK is now developed and released at github.com/ai-openshell/sdk-go, with versions that follow OpenShell releases. github.com/NVIDIA/OpenShell/sdk/go is deprecated; its last version is v0.1.8.

Testing

  • actionlint reports nothing in the changed workflows, and zizmor shows the same findings as main
  • mise lock leaves mise.lock unchanged
  • The compatibility validator accepts the nine remaining surfaces and rejects a review that lists go-sdk
  • rg 'sdk/go|go:ci|tag-sdk-go|sdk-go-freeze|go-sdk' over .github, tasks, .agents/skills, and the root docs finds no leftover references
  • Unit tests added/updated (not applicable)
  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

The Go SDK moved to github.com/ai-openshell/sdk-go (NVIDIA#5031), and the
final sdk/go tag carries the deprecation notice. Remove what is left of
it from this repository:

- sdk/go/, tasks/go.toml, and the Go toolchain and tools in mise.toml
  and mise.lock (nothing else here is written in Go)
- the Go entry, setup, and build steps in CodeQL, and sdk/go in the
  CodeQL config
- sdk-go-tag.yml and the tag-sdk-go job in release-publish.yml,
  including its needs entry and the expected-publisher check
- the Go SDK Freeze job in Branch Checks, which has nothing left to
  guard

docs/sdk/go.mdx now shows the new module path, pins the SDK version to
the gateway's, and keeps the migration steps from the old module that
were reviewed on NVIDIA#5245. README, CONTRIBUTING, AGENTS, TESTING, CI.md,
buf.yaml, and the Windows skill drop or redirect their sdk/go
references. Existing sdk/go/vX.Y.Z tags stay, so builds that use the
old module path keep working.

BREAKING CHANGE: github.com/NVIDIA/OpenShell/sdk/go is no longer
developed in this repository; use github.com/ai-openshell/sdk-go.

Signed-off-by: Roland Huß <rhuss@redhat.com>
With sdk/go removed, the compatibility review has no Go SDK left to
review. Remove go-sdk from the required surfaces in the review prompt
and in the report validator, which rejects reviews that don't cover
exactly the listed surfaces, and drop Go from the CI.md descriptions of
the compatibility review, CodeQL, and the release publishers.

Signed-off-by: Roland Huß <rhuss@redhat.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rhuss

rhuss commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

@SDAChess @elezar can I get anarea:sdk label for this PR ? Unfortunately its not possible for me to change the labels although they are mandatory.

An ok-to-test would be also great!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(sdk/go): remove the in-tree Go SDK after the final deprecated tag

1 participant