You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: move shared gRPC test fixture to tests/utilities - #2272
Follow-up to #2261 (review nit). Depends on it: this branch is stacked on #2261, so the diff shows its commits until that merges. The change itself is the last commit.
Moves grpc_integration_fixture.hpp and grpc_test_log_capture.hpp from cpp/tests/linear_programming/grpc/ to cpp/tests/utilities/grpc/.
The routing gRPC test no longer adds the LP test directory to its include path.
test_cpp_routing now excludes cpp/tests/linear_programming/grpc/**, so LP/MIP gRPC test changes no longer run the routing job.
Testing: not built locally; relies on CI. Include-only change.
Install a <TEST>.labels marker next to labeled test binaries and select on it
in run_ctests.sh. Fail if a group selects no binaries.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
GRPC_INTEGRATION_TEST keeps the LP/MIP cases; GRPC_ROUTING_INTEGRATION_TEST runs
SolveVRP and ChunkedUploadVRPWithPathLogging against a real server. The server
process and base fixture move to a shared header.
Keep cpp/src/grpc/routing shared since GRPC_CLIENT_TEST in the mathopt job covers submit_vrp, exclude presolve and tests/internal from routing, and stop polling on CANCELLED in the VRP gRPC test.
No actionable comments were generated in the recent review.
Walkthrough
The gRPC integration tests now use utilities/grpc/ include paths. The routing test target no longer includes the linear programming gRPC test directory, and the routing CI changed-file filter excludes that directory.
Changes: gRPC Test Path Separation
Layer / File(s)
Summary
Update gRPC test paths and routing filter .github/workflows/pr.yaml, cpp/tests/linear_programming/grpc/grpc_mathopt_integration_test.cpp, cpp/tests/routing/grpc/*
The integration tests use utilities/grpc/ include paths. The routing target removes the linear programming gRPC directory from its include paths, and the routing CI filter excludes changes under that directory.
NVIDIA/cuopt#2261: This PR updates the shared gRPC fixture include paths and completes the routing/mathopt CI filter split introduced by PR #2261.
NVIDIA/cuopt#2271: This PR also changes the routing/mathopt CI test partition.
Suggested reviewers:iroy30
Merge Risk: Minimal · up to 55efd
The relocation and CI gating are consistent, with no actionable merge-blocking risk identified.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: moving the shared gRPC test fixture to the tests utilities directory.
Description check
The description directly explains the fixture move, include-path cleanup, CI filter change, dependency context, and testing status.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ramakrishnap-nv
added
improvement
Follow-up to #2261 (review nit). Depends on it: this branch is stacked on #2261, so the diff shows its commits until that merges. The change itself is the last commit.
grpc_integration_fixture.hppandgrpc_test_log_capture.hppfromcpp/tests/linear_programming/grpc/tocpp/tests/utilities/grpc/.test_cpp_routingnow excludescpp/tests/linear_programming/grpc/**, so LP/MIP gRPC test changes no longer run the routing job.Testing: not built locally; relies on CI. Include-only change.
🤖 Generated with Claude Code