Repository navigation
test(audio): expect the spec-normalized square level from web-audio-api 1.8.0 - #207
Merged
Merged
Conversation
…pi 1.8.0 web-audio-api 1.8.0 scales the built-in square and sawtooth to the spec's normalized PeriodicWave (1.43 dB quieter), as Chrome does. Cargo.lock is not committed, so CI picked it up and the offline oscillator test, which still expected the old level, failed on Linux and Windows. Require 1.8.0 and expect its level.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
triniwiz
changed the title
triniwiz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since today, the Linux and Windows x64 native builds fail one test,
renders an oscillator through a gain offline. It fails the same way on every platform:rms 0.415166155667296. That breaks master CI and the 3.0.6 release.Cargo.lockisn't committed, and web-audio-api 1.8.0 was released today. It's the only crate that differs from the last passing build. Its changelog includes:The square oscillator now uses the spec's normalized
PeriodicWave, as Chrome's does. The band-limited square overshoots by about 1.179 (the Gibbs peak), so it is scaled until its peak is 1. At gain 0.5 the render now peaks at 0.424 with an RMS of 0.415, where the test expected 0.5.Changes:
web-audio-api = "1.8.0", so no build can resolve the old, louder output.Locally, with the addon built against 1.8.0, the oscillator test passes. It renders offline, so the result doesn't depend on the platform.