Repository navigation
Conversation
… resolves to Local clippy on an older stable (1.96.1, this machine's installed default) flags 2 nonminimal_bool lints CI's clippy job does not, on code no branch here touches -- a false preflight failure every push has to work around with RUSTUP_TOOLCHAIN=1.99.1. CI pins no fixed version: the main test/clippy job (.github/workflows/test.yml) runs on whatever dtolnay/rust-toolchain's 'stable' channel resolves to on the day it runs, currently 1.99.1. rust-version in Cargo.toml (1.96) is the workspace's minimum supported version, checked by a separate msrv job -- not what the lint job runs on, and not what this pins. This snapshots today's CI stable. It needs bumping again whenever CI's stable moves and local rustup drifts behind it -- there is no way to pin to 'always match CI' without a fixed version number somewhere.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local clippy on an older stable (1.96.1, a contributor machine's installed default) flags 2
nonminimal_boollints CI's clippy job does not, on code no branch touches — a false preflight failure every push has to work around withRUSTUP_TOOLCHAIN=1.99.1.CI pins no fixed version: the main test/clippy job (
.github/workflows/test.yml) runs on whateverdtolnay/rust-toolchain'sstablechannel resolves to on the day it runs, currently1.99.1.rust-versioninCargo.toml(1.96) is the workspace's minimum supported version, checked by a separatemsrvjob — not what the lint job runs on, and not what this pins.This snapshots today's CI stable. It needs bumping again whenever CI's stable moves and a contributor's local rustup drifts behind it — there is no way to pin to "always match CI" without a fixed version number somewhere.