Skip to content

build: pin the dev toolchain to the version CI's stable job currently resolves to - #514

Draft
EnRaiha wants to merge 1 commit into
NodeDB-Lab:mainfrom
EnRaiha:fix/pin-rust-toolchain
Draft

EnRaiha wants to merge 1 commit into
NodeDB-Lab:mainfrom
EnRaiha:fix/pin-rust-toolchain

Conversation

@EnRaiha

@EnRaiha EnRaiha commented Nov 22, 2026

Copy link
Copy Markdown
Contributor

Local clippy on an older stable (1.96.1, a contributor machine's installed default) flags 2 nonminimal_bool lints CI's clippy job does not, on code no branch touches — a false preflight failure every push has to work around with RUSTUP_TOOLCHAIN=1.99.1.

CI pins no fixed version: the main test/clippy job (.github/workflows/test.yml) runs on whatever dtolnay/rust-toolchain's stable channel resolves to on the day it runs, currently 1.99.1. rust-version in Cargo.toml (1.96) is the workspace's minimum supported version, checked by a separate msrv job — not what the lint job runs on, and not what this pins.

This snapshots today's CI stable. It needs bumping again whenever CI's stable moves and a contributor's local rustup drifts behind it — there is no way to pin to "always match CI" without a fixed version number somewhere.

… resolves to

Local clippy on an older stable (1.96.1, this machine's installed
default) flags 2 nonminimal_bool lints CI's clippy job does not, on
code no branch here touches -- a false preflight failure every push
has to work around with RUSTUP_TOOLCHAIN=1.99.1.

CI pins no fixed version: the main test/clippy job
(.github/workflows/test.yml) runs on whatever dtolnay/rust-toolchain's
'stable' channel resolves to on the day it runs, currently 1.99.1.
rust-version in Cargo.toml (1.96) is the workspace's minimum supported
version, checked by a separate msrv job -- not what the lint job runs
on, and not what this pins.

This snapshots today's CI stable. It needs bumping again whenever CI's
stable moves and local rustup drifts behind it -- there is no way to
pin to 'always match CI' without a fixed version number somewhere.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant