Repository navigation
reject invalid and conflicting Content-Length in httpGetLength - #219
Closed
tanjiroK-coder wants to merge 1 commit into
Closed
tanjiroK-coder wants to merge 1 commit into
tanjiroK-coder wants to merge 1 commit into
Conversation
michaelrsweet
left a comment
Member
There was a problem hiding this comment.
I think I want to refactor this change, and limit any changes to the library and not the unit test program (for now at least).
Also, for future PRs:
- Currently testhttp does not try to simulate requests/responses, and any such changes should be contributed as a separate PR as it will be a huge amount of maintenance.
- Please just put your suggested changelog test in the description of the PR; at the very least I'll be adding the issue/PR number and I almost always reword things.
Member
|
FWIW, RFC 9110 has a fair amount to say about Content-Length, and allows an implementation to reject multi-value lengths. So I will be marking Content-Length as potentially multi-valued and reject any header containing anything other than "1*DIGIT". |
michaelrsweet
added a commit
that referenced
this pull request
Nov 19, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpGetLengthparsed Content-Length withstrtoll(value, NULL, 10), so5abc,+5and5, 50all framed a 5-byte body, andhttp_add_fieldlet a second Content-Length field replace the first, soContent-Length: 5followed byContent-Length: 50framed 50 bytes.httpGetLengthreturn -1, which_httpUpdatealready reports as a bad Content-Length, the same path now used for unknown Transfer-Encoding values.The new loopback cases in testhttp fail 4 of 7 on master (got 50, 5, 5, 5 where -1 is expected) and all pass with this change; single, repeated identical and
5, 5values still return 5.