Repository navigation
Fix undefined mutex initializer in Windows thread backend - #113
Merged
tillkamppeter merged 1 commit intoNov 18, 2026
Conversation
ppd_global_mutex, the lazy-init guard for per-mutex CRITICAL_SECTION initialization in the Windows (_WIN32) branch of this file, was initialized with _CUPS_MUTEX_INITIALIZER. That macro does not exist anywhere in this codebase -- the header right above it only defines _PPD_MUTEX_INITIALIZER (for all three threading backends: pthreads, Windows, and none). Nothing in the included headers defines it either, so this is a plain undeclared-identifier error wherever this file actually gets compiled for Windows, which the project's CI never exercises (no Windows build/test job, and the only thread-safety test for this file uses pthreads unconditionally). Use the macro this header actually defines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows branch initializes ppd_global_mutex with _CUPS_MUTEX_INITIALIZER, which is not defined in this codebase. The local header defines _PPD_MUTEX_INITIALIZER for each threading backend. Use that macro so the Windows implementation compiles.