Repository navigation
fix(windows): rebuild the release pipeline on one version number - #23
Conversation
The last Windows release went out as v0.1.4, below the earlier v1.0.3, and the executable inside it still reported 1.0.2: the csproj had GenerateAssemblyInfo=false and the version lived in a hand-edited AssemblyInfo.cs that CI never touched. Release notes were commit lists. - csproj <VersionPrefix> (now 1.0.4) is the single source of truth; assembly attributes are generated from it. AssemblyInfo.cs keeps only ThemeInfo. - New .github/workflows/windows-build.yml builds installer + 4 portable exes + SHA256SUMS on every windows/ change; a vX.Y.Z tag publishes the release and fails if the tag differs from <VersionPrefix> or windows/CHANGELOG.md has no matching section. Embedded versions are verified after publish. - Remove build-and-release.yml (quotes escaped as \", triggers on a non-existent main branch, calls a script path that does not exist) and the old dotnet-build.yml it duplicated. - windows/CHANGELOG.md holds user-facing notes; release-notes-footer.md adds the download table, requirements and the SmartScreen note. - installer.nsi accepts PUBLISH_DIR / LICENSE_FILE; the repository LICENSE is one level above windows/. Local build scripts pass the version through MSBuild properties instead of rewriting AssemblyInfo.cs. - In-app update check points at PCcoding666/LCT instead of older repos. - windows/docs/dev/RELEASE.md documents the checklist. Not verified locally (no Windows/.NET here): the workflow runs on this PR. Code signing is still missing; see RELEASE.md. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 141a212fea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…staller windows-latest no longer ships NSIS, so the installer step failed with "makensis not found" after all five publishes succeeded. Install it with Chocolatey when missing. ReleaseInfo.GetInstallerAsset() required "x64" in the asset name, which LCT-vX.Y.Z-Setup.exe never had, so in-app updates always ended with "No suitable installer found". The installer is x64 only; exclude only an explicitly ARM64-named installer instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Summary
The last Windows release was published as v0.1.4, below the earlier v1.0.3, and the exe inside it still reports 1.0.2:
GenerateAssemblyInfowas off and the version lived in a hand-editedAssemblyInfo.csthat CI never updated. Release notes were raw commit lists. This PR puts the Windows release on one version number and one set of user-facing notes.windows/LiveCaptionsTranslator.csproj<VersionPrefix>(now 1.0.4) is the single source of truth; assembly/file/product versions are generated from it.AssemblyInfo.cskeeps onlyThemeInfo..github/workflows/windows-build.yml: every change underwindows/builds the NSIS installer, four portable exes (x64/ARM64 × with/without runtime) andSHA256SUMS.txtas an artifact. AvX.Y.Ztag publishes the GitHub Release and fails on purpose if the tag ≠<VersionPrefix>orwindows/CHANGELOG.mdhas no## [X.Y.Z]section. Embedded versions are checked after publish.build-and-release.yml(every quote escaped as\", triggers on a non-existentmain, references a script path that does not exist) and the olddotnet-build.ymlit duplicated.windows/CHANGELOG.md(user-facing notes) +windows/docs/dev/release-notes-footer.md(download table, requirements, SmartScreen note) form the release body.installer.nsitakesPUBLISH_DIR/LICENSE_FILE; the repoLICENSElives one level abovewindows/.PCcoding666/LCT(wasSakiRinn/...andPCcoding666/LiveCaptions-Translator).windows/docs/dev/RELEASE.md: release checklist.Test plan
windows-latest, the "Verify embedded version" step printsFileVersion=1.0.4.0/ProductVersion=1.0.4-ci.N+….build-installer.bat,build-version.ps1) were edited blind — no Windows here.Follow-ups (not in this PR)
CHANGELOG.md, tagv1.0.4, then consider marking the oldv0.1.4release as pre-release so "Latest" is unambiguous.🤖 Generated with Claude Code