Repository navigation
In-App Messaging - #14
Merged
Merged
Conversation
pyios_firebase.in_app_messaging wraps Firebase In-App Messaging: - InAppMessaging: message_display_suppressed, automatic_data_collection_enabled, trigger_event (checked), and impression / click / dismiss / error listeners through a Python FIRInAppMessagingDisplayDelegate - typed messages: ModalMessage, BannerMessage, CardMessage, ImageOnlyMessage, with CampaignInfo, ImageData, ActionButton, Action; colors as "#RRGGBB" - set_display(handler): show messages with Python (a Kivy popup) through a DisplayDelegate that reports impression, click, dismiss or failure once; a raising handler fails the message so Firebase does not wait forever. use_default_display() restores Firebase's screens - in_app_messaging() before configure raises RuntimeError (the SDK gives nil) Unit tests, the typing check, docs pages (usage and reference), README additions, and e2e tests: settings, a Python display called as Firebase calls it, and Firebase's default modal over the Kivy window with its impression and a tap on its button reaching the listeners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Looks great, approving this one — thanks so much!
Produced by Air Automations. Name: Code Review / Run: https://air.jetbrains.cloud/org/a114b0a9-2e82-18ec-abd3-29d0c8a05e2d/automations/c07b9901-fe4e-417d-ae1d-e00c83e39e4c?run=b7b862bf-e2d2-4fdd-8b4d-5f094ce81720
Merged
kengoon
added a commit
that referenced
this pull request
Nov 12, 2026
Since 0.2.1: - In-App Messaging: pyios_firebase.in_app_messaging, with settings, event triggers, impression / click / dismiss / error listeners, typed messages, and set_display() to show messages with Python (#14) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps Firebase In-App Messaging (
pyios_firebase.in_app_messaging), a separate product from Cloud Messaging.InAppMessaging.in_app_messaging():message_display_suppressed,automatic_data_collection_enabled,trigger_event(name)FIRInAppMessagingDisplayDelegateModalMessage,BannerMessage,CardMessage,ImageOnlyMessageCampaignInfo,ImageData(with the downloaded bytes),ActionButton,Action"#RRGGBB"strings; the campaign's custom data is inapp_dataset_display(handler)shows messages with Python (for example a Kivy popup):DisplayDelegatereports the impression, then exactly one click, dismiss or failure;use_default_display()restores Firebase's screens.in_app_messaging()beforeconfigureraisesRuntimeError(the SDK returns nil);ValueError;RuntimeError.Tests
mkdocs build --strictpasses.trigger_eventchecks;FIRIAMDefaultDisplayImpl) shown over the Kivy window, with its impression (after 3 s on screen) and a tap on its real button reaching the listeners.🤖 Generated with Claude Code