Repository navigation
perf: Stop reading stale Paper heartbeat slots - #744
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pigbibi
added
the
agent-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex.
What changed
Check collector heartbeat slots newest first. Stop reading once a heartbeat's timestamp is inside the existing freshness window. Keep the four-slot fallback, alert cadence and deduplication behavior.
How verified
94 focused Paper observation tests passed, including recent, exact-boundary and stale heartbeats. Ruff, documentation check, diff checks and staged Gitleaks passed.
Why
A healthy collector usually writes the newest slot, so the watchdog can avoid three redundant object reads.
Risk
The watchdog is a monitoring component. The change preserves all schedule and resource configuration, uses the same heartbeat schema and does not alter broker calls or collector writes.