Repository navigation
Conversation
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
| throw(DimensionMismatch("size of S ($r) must be between k ($k) and min(size(A)...) ($minmn)")) | ||
| (size(U, 1) == m && k ≤ size(U, 2) ≤ m) || | ||
| throw(DimensionMismatch("size of U $(size(U)) must be ($m, r) with r between k ($k) and $m")) | ||
| (size(Vᴴ, 2) == n && k ≤ size(Vᴴ, 1) ≤ n) || | ||
| throw(DimensionMismatch("size of Vᴴ $(size(Vᴴ)) must be (r, $n) with r between k ($k) and $n")) |
There was a problem hiding this comment.
For these small interpolations, I don't know if it is worth using LazyString. We have probably not been using this very consistently, though we do use it at some places in the ecosystem.
There was a problem hiding this comment.
I don't think it hurts at all, so I can add it in.
|
I realized this will currently fail with AD so I'm adding some logic to handle that too |
|
I'm still not entirely convinced by the current logic of the randomized SVDs through |
|
Totally fine with me, I had no idea whether that one was still alive or not |
This makes
svd_trunc!andsvd_trunc_no_error!producek-sized outputs so that we can avoid calling the internalgesvdxrfunctions. Also has a fix for the truncation so that if we pass in inputs which are "too big", we pass views that fit.