You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[WIP] Add new Scalar type for GPU performance - #60
I think a DenseArray can be N-dimensional which isn't really a Vector, so I've updated that and created a BLASMatrix and BLASArray pair to encapsulate things that should be allowed.
So currently this doesn't make use of the device-side storage in cuBLAS and rocBLAS. If we like the overall approach, I will then add some specializations via extensions here and elsewhere that will use them.
After talking with @Jutho we're going to try having the GPU inner and norm return Scalar, and get rid of the in-place (bang !) methods. I'll try to make a PR to KrylovKit with the new changes and see what we think of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea is to allow us to take advantage of JuliaGPU/CUDA.jl#2616 and the AMDGPU equivalent by avoiding round-trip copies when using VI with GPU arrays.