Repository navigation
Conversation
SamNet-dev
added a commit
that referenced
this pull request
Nov 8, 2026
…roxy (#162, #165) - Replace Bash-specific ${TELEMT_COMMIT:0:7} in Dockerfiles with POSIX printf '%.7s'`n to avoid '/bin/sh: Bad substitution' errors under Debian dash during source builds (#162) - Safeguard update and rebuild workflows so running proxy containers are never stopped or destroyed if image acquisition or compilation fails - Clarify source build failure message to guide users to docker build logs - Extend tests/test_engine_image.sh and add tests/test_engine_update_safeguard.sh Co-authored-by: rmtshnik <iron-chaos-purging@duck.com>
Owner
|
Thank you @rmtshnik! This has been resolved on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telemt 3.5.16 (
84e5b82) can fail before Cargo starts because both Dockerfiles use the Bash-only${TELEMT_COMMIT:0:7}expansion in aRUNinstruction executed by/bin/sh.Use POSIX
printf '%.7s'in the installer-generated Dockerfile and the engine build workflow. Update the engine image test to check the generated command.Validation
tests/test_engine_image.shpassed.RUNcommands accepted short and full commit IDs and rejected a mismatched ID with mocked Git in Bash POSIX mode.dashexecution were not run.Related to #162. This PR addresses the source-build shell error described there.