Repository navigation
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
runId,algorithmId,status, andoutputwith the ephemeral P-384 key it already registers in its Nitro attestation document.sce-unitstreams a base64 payload plus DER signature to the host. The host only forwards the envelope and addsinstanceId.public_keyon theRunAttestationTablerow at/attest, rejects a document without one, and exposesGET /runs/{runId}.runId, verifies the signature and signedalgorithmId, then persists only verified fields.why
The host is untrusted, so it could previously fabricate or change any stored result before
sqs:SendMessage. Signing inside the enclave binds the result to the measured image and makes forged values fail verification. Closes #93.This does not fix #120: the host still chooses the
runIdit serves to the enclave, so a host can ask the enclave to sign a result for another unattested run.verification
cd secure/sce-unit && gofmt -l . && go vet ./... && go build ./...passes.cd secure/result-consumer && bun run lint && bun run typecheckpasses.cd secure/verifier-service && bun run lint && bun run typecheckpasses.cryptocall the consumer uses, including non-ASCII output.1a8fa043-7ce4-422d-86be-f5bf5fef78eereturnedexit:0and persisted the expected health-risk output. Consumer and verifier logs show the run attestation fetch and the verified result.runIdwith a bogus signature. result-consumer loggedskipping result with invalid signature, andGET /run/{runId}still returned the original output.notes
pending. That is deliberate under the Result integrity: a compromised enclave host can forge run results #93 threat model, but it removes the old unsigned failure record.main, because the live stack was older than the current encrypted-envelope shape.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.