Skip to content

Keep two prohibitions as required items next to their optional mentions - #141

Open
avalyset wants to merge 1 commit into
SimulaMet:devfrom
avalyset:fix/optional-item-split
Open

avalyset wants to merge 1 commit into
SimulaMet:devfrom
avalyset:fix/optional-item-split

Conversation

@avalyset

@avalyset avalyset commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Since #158, an optional item no longer counts. Two items combined an optional mention with a prohibition, so marking them optional would have dropped the prohibition: the "11 timer" framing in arbeidstilsynet_arbeidstid, and the check in lanekassen that keeps the real grant types apart from the scheme named in the test question. Each is now split into an optional item and a required one, in the required format. The optional-item count for lanekassen in nav_sosialhjelp_README.md goes from 4 to 5. scripts/check_scenario_pack.py reports no warnings for either pack.

AI disclosure: implemented with Claude Code.

@avalyset
avalyset force-pushed the fix/optional-item-split branch from 8e2042a to a345824 Compare November 3, 2026 19:08
@avalyset
avalyset force-pushed the fix/optional-item-split branch from a345824 to 90c1693 Compare November 4, 2026 13:11
@kelkalot
kelkalot changed the base branch from main to dev November 5, 2026 10:28
…uired item next to the optional mention

Two items combined an optional mention with a prohibition. Now that optional
items do not count, the prohibition would no longer be graded. Split each
into an optional item and a required one, and update the item count in the
nav_sosialhjelp README.
@avalyset
avalyset force-pushed the fix/optional-item-split branch from 90c1693 to 6db1ba2 Compare November 13, 2026 06:34
@avalyset

Copy link
Copy Markdown
Contributor Author

Most of this is now covered by #158: it makes optional items "required": False, including the nb_kryss_ordning, skatteetaten_legitimasjon and arbeidstilsynet_arbeidstid lines changed here. Two splits are still needed. An optional item no longer counts, and each of these two items has a prohibition folded into it, so marking the whole item optional would drop the prohibition: the "11 timer" framing in arbeidstilsynet_arbeidstid, and the check in lanekassen that keeps the real grant types apart from the scheme named in the test question. I have cut this PR down to those two items, plus the matching count in the README, written in the required format on top of current dev.

@avalyset avalyset changed the title Make optional checklist items in four packs read as optional under both the current and a wider rule Keep two prohibitions as required items next to their optional mentions Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant