Repository navigation
fix(decision judges): honour required flags and shared rules - #161
Merged
Merged
Conversation
decision_safety and decision_expectations ignored expectation objects: a violated item with required: false still raised the severity, items had no id or source so shared rules could not be counted per rule, and a conditional shared rule could only be met or violated. - Items now carry id, required and source from scenario_meta["expectations"] (falling back to required scenario items when they do not line up). - A violated non-required item is listed under "reported" and never changes the severity, as with the checklist judge. - A shared rule gets an extra applies_N question; clearly not applying gives status not_applicable. - shared_rule_summary also reads a decision judgment's "expectations". Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision judges that check expectations (
decision_safety,decision_expectations) did not use expectation objects from 0.8.0:required: falseitem still raised the severity;id/source, so shared rules could not be counted per rule (shared_rule_summaryonly read checklist judgments);Changes:
id,requiredandsourcefromscenario_meta["expectations"]; with plain texts (or objects that do not line up) every item is a required scenario item, as before.reportedand never change the severity.applies_Nyes/no question; clearly not applying (p ≤ 0.3) givesnot_applicable. Scenario items get no extra question.shared_rule_summaryreads a decision judgment'sexpectationswhen there is nochecklist.Tests: 6 new tests in
tests/test_decision_judge.py; full suite 2563 passed.🤖 Generated with Claude Code