Repository navigation
improved messaging around delete container - #805
Merged
Merged
Conversation
…@5.0.2-8 pane-registry@5.0.2-3 folder-pane@4.0.1-2 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Deletion tests lack container-specific warning and success-message assertions, as well as a regular-file check that the warning is absent, leaving the new messaging unprotected against regressions.
1 open issue
What changed in this PR
Improves deletion messages in the internal pane to clarify that deleting a container also deletes its contents, addressing issue #804.
Changes:
- Adds an explicit contents warning to container deletion confirmations.
- Updates success messages to distinguish container deletion from file deletion.
| File | Description |
|---|---|
src/internal/internalPane.ts |
Adds container-specific confirmation and success messages. |
Review effort: Balanced
Member
Author
|
small counterpart over in solid-logic: SolidOS/solid-logic#357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #804