Repository navigation
fix navigation state - #806
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Safari navigation-state changes.
No open issues 🎉
What changed in this PR
Fixes navigation state handling when Safari reports application history writes as user-initiated navigation, preserving pane selection without interfering with address-bar navigation.
Changes:
- Adds a guarded history-write helper and ignores synchronous navigation events during application writes.
- Routes outline and pane-state history updates through the helper, with logging for outline history failures.
- Adds regression tests for Storage selection, recursive interception, and guard cleanup, and documents the behavior.
| File | Description |
|---|---|
test/unit/navigation/browserEvents.test.ts |
Tests Safari-style history events and guard cleanup after errors. |
test/unit/mainPage/navbar.test.ts |
Verifies Storage remains selected during a Safari-style history event. |
src/outline/manager.js |
Uses guarded history writes and logs history-update failures. |
src/navigation/state.ts |
Adds the history-write guard and applies it when clearing pane state. |
src/navigation/browserEvents.ts |
Skips interception during guarded application history writes. |
docs/navigation-design.md |
Documents guarded writes and Safari navigation handling. |
Review effort: Balanced
…@5.0.2-8 pane-registry@5.0.2-3 folder-pane@4.0.1-2 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
SharonStrats
approved these changes
Nov 9, 2026
SharonStrats
left a comment
SharonStrats
left a comment
Contributor
There was a problem hiding this comment.
Looks good, so quirky. We have too many "flows" I feel like. It's hard to keep track of each and very one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.