Repository navigation
Fix Profile not working on safari and mobile - #808
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Mocked tests cannot validate Safari/iOS navigate-event metadata or dispatch timing, so account-menu profile rendering and Enter-on-current-URL behavior require verification in a real Safari/iOS browser.
No open issues 🎉
What changed in this PR
This PR addresses Safari and mobile profile rendering failures by distinguishing application history writes from user navigation, preventing unintended refreshes that disrupt the profile view and heading.
Changes:
- Ignore same-URL history replacements while preserving Enter-key navigation handling.
- Expand regression tests for delayed Safari history events, missing metadata, and navigation without fragments.
| File | Description |
|---|---|
test/unit/navigation/browserEvents.test.ts |
Adds navigation metadata and regression coverage for Safari history writes. |
src/navigation/browserEvents.ts |
Filters history-write events to avoid unintended profile restoration. |
Review effort: Balanced
Prompt: There are multiple refreshes happening on mobile and safari that cause the profile not to be rendered, when it does render the heading is not present Co-authored-by: Claude Opus 5.5 <claude-5.5-opus@openai.com>
SharonStrats
force-pushed
the
fix/safari
branch
from
November 9, 2026 22:15
c6d4fa6 to
d7356d7
Compare
…@5.0.2-8 pane-registry@5.0.2-3 folder-pane@4.0.1-2 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are multiple refreshes happening on mobile and safari that cause the profile not to be rendered, when it does render the heading is not present.
Both 806 PR and this one are needed they solve different problems. Everything is explained here
https://sharontest.solidcommunity.net/public/SolidOS%20Documents/SafariProblems.md