Repository navigation
[feat] providers: add Zhipu BigModel GLM chat support - #245
Merged
Merged
Conversation
MrDongsls
marked this pull request as ready for review
November 9, 2026 16:57
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
- Register the Zhipu BigModel provider preset with its canonical URL, the Z.ai brand logo and the GLM agent model catalog. - Map the shared thinking levels to GLM reasoning_effort in the shared chat payload. GLM accepts only low, high and max, auto omits the parameter and unknown levels fall back as in the DeepSeek branch. - Cover the preset shape, bilingual labels, saved connection identity and effort mapping with tests, and the provider form and assistant picker with an isolated browser case. - .venv/bin/python -m pytest tests -q: 1083 passed, 6 skipped - npm test: 678 passed - npm run build - npm run check:i18n - CREATION_API_URL=http://127.0.0.1:8019 CREATION_WEB_URL=http://127.0.0.1:5179 node tests/browser/zhipu_provider.mjs - Real credential acceptance: streaming conversation, tool call execution and both display languages verified against open.bigmodel.cn with screenshots. Refs: ThinkFlowLab#236
MrDongsls
force-pushed
the
feat/zhipu-glm-chat
branch
from
November 9, 2026 16:59
242906a to
a4bb700
Compare
Contributor
|
fix conflicts |
hsliuustc0106
added
type:feat
Contributor
Author
|
Conflict already fixed in |
FayeSpica
requested changes
Nov 10, 2026
FayeSpica
left a comment
FayeSpica
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Please fix the browser manifest check before merging.
8 tasks
## summary - Register the Zhipu provider browser workflow in the extended lane. - Reuse the assistant picker check for both Chinese and English labels.
## summary - Run Chinese and English picker checks on fresh pages and projects. - Keep saved model configuration shared while avoiding assistant state and project lease interference. ## validation - node tests/browser/zhipu_provider.mjs - node --check tests/browser/zhipu_provider.mjs - git diff --staged --check Signed-off-by: MrDongsls <dhy1042542469@126.com>
Contributor
Author
|
@FayeSpica Thanks for your review! Both problems are addressed in |
Collaborator
|
Let’s wait for CI to pass before moving forward. |
Contributor
Author
|
@FayeSpica I investigated the CI failure and found it was an intermittent storage_busy session-lease race during voice-library cold reopen (the PR does not touch that path); could you please re-run CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #236. Parent RFC: #234
Summary
https://open.bigmodel.cn/api/paas/v4, the Z.ai brand logo and a curated GLM agent model catalog, so GLM models appear in the assistant Default group exactly like other chat providers. The preset ships a fixed model list because the platform does not document a model listing endpoint; manual model IDs stay available.Evidence
asset write-text, added it to the canvas withcanvas add-material, and reported the executed steps; the text node appeared on the canvas.Both acceptance items from the issue were verified with the real connection: a streaming conversation, and an assistant turn that called OpenDirector tools, received results and continued the conversation. One of six tool calls in that run failed and the agent loop recovered on retry; the final canvas state and reply were correct.
Validation
.venv/bin/python -m pytest tests -q: 1260 passed, 7 failed, 6 skipped at 242906a. The 7 voice library failures also fail on upstream main f06e22f without this commit, so they are pre-existing on the rebased basenpm test: 695 passed, 0 failednpm run buildnpm run check:i18nCREATION_API_URL=http://127.0.0.1:8019 CREATION_WEB_URL=http://127.0.0.1:5179 node tests/browser/zhipu_provider.mjs: passed, no request reaches open.bigmodel.cn