Repository navigation
[bugfix] projects: reopen a reloaded tab's own lease and name the other-window conflict (#277) - #279
Open
Zhangbo-cn wants to merge 1 commit into
Open
Zhangbo-cn wants to merge 1 commit into
Zhangbo-cn wants to merge 1 commit into
Conversation
…er-window conflict (ThinkFlowLab#277) ## summary - Keep the previous page's session ID in `sessionStorage`. Before its first request, a reloaded tab releases that session when no live page still holds its Web Lock, so a crashed or killed page no longer blocks the reload for the 60 s lease. A duplicated tab copies `sessionStorage` but finds the original's lock held, so it never releases a live window. - Give "project open in another window" its own `project_open_elsewhere` code with bilingual text. `storage_busy` again means only a storage lock timeout; it keeps its retries and `Retry-After`. Only a reloaded tab waits briefly on its own lease; a fresh window is refused at once. ## validation - `pytest`: 1581 passed, 98 skipped; `npm test`: 760 passed; `tsc`, `build`, `check:i18n`, `check:browser-manifest`: clean. - New gate script `tests/browser/session_lease.mjs` (zh-CN, en-US): reload with a dropped release reopens in about 2 s with no 409, and a second window is refused with `project_open_elsewhere`. On `main` the reload times out. - `scripts/run-browser-suite.mjs`: 20/20 passed on fresh fixture services.
Zhangbo-cn
requested review from
hsliuustc0106 and
princepride
as code owners
November 10, 2026 14:41
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessionStorage.sessionStorage, but it finds the original window's lock still held, so it never releases a live window.project_open_elsewhere.storage_busyagain means only a storage lock timeout, which keeps its retries andRetry-After.Linked issue
Labels
type:bug,area:canvas,area:i18n. I can't apply labels from a fork.Test plan
pytest: 1581 passed, 98 skipped.npm test: 760 passed, including the newtests/sessionLease.test.ts.tsc --noEmit,npm run build,npm run check:i18nandnpm run check:browser-manifestare clean.tests/browser/session_lease.mjs:project_open_elsewhere.main, the same reload times out.scripts/run-browser-suite.mjspassed 20/20 on fresh fixture services.Evidence that it works
Provider verification
Bilingual UI