Repository navigation
Conversation
HugoXK
changed the title
HugoXK
changed the title
The gate counts a PASS only when one report carries a Tip SHA line naming the head and a Verdict at or after it, so on 2026-11-09 #774/#776/#782 read as "says nothing at this tip" while the owner's agent had a PASS at the right tip. These tests pin both shapes (Verdict above the tip line, and an inline `Verdict: PASS (tip <sha>)`), keep a short sha that is not the head NOT PASS, keep the tip and its verdict in one report body, and mark an evidence-less PASS `weak: no Ran:/Not run:` instead of dropping it. Red on main: the three shape tests fail; the fix follows separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #915.
What changed
Red tests only in this PR; the fix to
.github/scripts/review_gate.pyfollows in a later commit.tests/test_process_review_gate.pynow pins the two shapes the owner's agent writes —Verdict: PASSabove theTip SHA:line (#774) andVerdict: PASS (tip b0a30224)with noTip SHA:line (#776/#782) — and keeps the bar where it is: a 7-hex tip that is not the head stays NOT PASS, a tip in another comment stays NOT PASS, and an evidence-less PASS counts only asweak: no Ran:/Not run:. The old rejection of a PASS withoutRan:/Not run:is replaced by that marker. One changelog fragment.At this tip the gate still reads both shapes as "says nothing at this tip", so the three shape tests fail as intended.
Verification at the tip
Tip SHA:
ce1cf9e75c9a38cb9e154b253bebda6d5e1a5384Ran:
python3 -m pytest tests/test_process_review_gate.py -q→ 12 passed, 3 failed (the red:test_a_pass_without_evidence_counts_but_is_marked_weak,test_a_verdict_above_the_tip_line_counts,test_a_verdict_carrying_its_tip_inline_counts)python3 -m tools.changelog_fragments check→ 64 fragments OKpython3 -m pytest tests/test_changelog_fragments.py -q→ 45 passedNot run:
pytest -q— never finishes on this host (killed at 84% after 28 minutes), so the touched gate file and the changelog check are run directlymkdocs build --strict— nodocs/ormkdocs.ymlchange