Repository navigation
Unreg to reg transform - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Support for unregulated to regulated transforms. User builds an unregulated-regulated transform function using
unreg_reg_transform(). The resulting function is input intorfa_simulate()and the sampled unregulated inflow value will be converted to its corresponding regulated inflow value.testthat(),document(),check(), andgit addhave all been executed more times than I can count. It's been a while!Between this, rejection sampling, and plot utilitis,
rfaRversion is bumped to 0.9.0. No major functional changes expected between 0.9.0 and 1.0Related Issue
Closes #25
Type of change
Checklist
devtools::document()has been rundevtools::check()passes with zero errors, warnings, and notestestthat)NEWS.mdhas been updated (if user-facing)