Repository navigation
Conversation
panel: menu: add menu and filter a11y labels
panel: tray: rewire tooltips to be set based on changes, not only polled when shown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(a11y is shorthand for accessibility, for those who don't know)
This is a draft currently.
The wf-shell shortcut key has been co-opted and used as an accessibility toggle.
Once the user presses the shortcut, the panel is exclusive keyboard focus until ESC or the shortcut is pressed again.
Labels, Descriptions have been liberally strewn throughout the code so that navigating with Tab, Shift-Tab, Menu, and Enter and using a screen reader results in an interface that is close to as usable as current usage.
To assist in debugging, when in exclusive focus mode the currently focused widget is shown with an outline.
I have pushed this branch earlier than planned in hope to get more eyes on it and its short comings.
Of note:
After these are fixed, we then need to decide how (also if) we add a proper shortcut to toggle this mode.
For one option, we could add one more shortcut key to wf shell unstable protocol, and keep the panel much as it is in this PR. This will work fine, but leaves other panels with no way to follow suit.
The second option requires a bit more effort. For this one I propose we create an accessibility plugin for wayfire which has a user configurable shortcut. When pressed, this cycles through layer-shell layers with ON_DEMAND keyboard focus set, bringing it into focus, and cycling back to window focus.