Repository navigation
Credit Impeccable's Apache-2.0 files properly; restate README positioning - #128
Merged
Merged
Conversation
…tioning The seven files in references/design-system/ from 2026-03-15 are unchanged copies of Impeccable's frontend-design references at 6d8c851. Ship the Apache-2.0 text and a NOTICE (with Impeccable's own NOTICE), mark each file, and include both in the Codex package. README now opens with the llms.txt positioning and says what was copied instead of 'powered by Impeccable'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…audit done Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I found
TODO asked whether we copied Impeccable text. We did. The 7 files added to
references/design-system/on 2026-03-15 (commit 85e86d4) are byte-identical copies of Impeccable'ssource/skills/frontend-design/reference/*.mdat Impeccable commit6d8c851, the last commit before that date:Method:
diffshows 0 changed lines.Elsewhere the overlap is negligible: under 10 shared 10-word runs per file. These are standard Nielsen heuristic wording and common code idioms such as an
IntersectionObserverloop orIntl.NumberFormat.Impeccable is Apache-2.0. Redistribution requires shipping the license, keeping the NOTICE attributions and marking changed files. The repo did none of these.
What this PR does
NOTICE:LICENSES/Apache-2.0.txt: Impeccable's LICENSE file at that commit.build-plugin.pyshipsNOTICEand the license text in the Codex package.llms.txtpositioning: complete, comparable directions; snapshot undo; never overwriting unseen changes./aboutmeta description: "one prompt, three visual directions" becomes the task / tradeoffs / snapshot-undo framing.llms.txt, prerendered descriptions and site copy contain no "only", "first", "unique" or "独有" claims about producing three versions.This is not legal advice. Whether to keep the copies, rewrite them in our own words, or contact the author is your call; TODO now says so.
Checks that ran
node --test scripts/*.test.mjs: 52 passed.python3 scripts/plugin-package.test.py: OK, with the new notice test.npm test: 58 passed.🤖 Generated with Claude Code