Repository navigation
Conversation
* fix(python): add opt-in sandbox delete timeout Signed-off-by: Eric Curtin <eric.curtin@docker.com> * fix(python): omit delete timeout unless set Signed-off-by: Eric Curtin <eric.curtin@docker.com> * fix(python): fix delete test typing Signed-off-by: Eric Curtin <eric.curtin@docker.com> * test(python): tighten delete timeout coverage Signed-off-by: Eric Curtin <eric.curtin@docker.com> * fix(python): rename delete timeout to timeout_seconds Signed-off-by: Eric Curtin <eric.curtin@docker.com> --------- Signed-off-by: Eric Curtin <eric.curtin@docker.com> Signed-off-by: Taylor Mutch <taylormutch@gmail.com> Co-authored-by: Taylor Mutch <taylormutch@gmail.com>
TaylorMutch
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from NVIDIA/OpenShell#4697 (NVIDIA/OpenShell#4697) by ericcurtin, after the Python SDK moved out of NVIDIA/OpenShell at 5d25211b25a8fc887e8d5c606d57d6ab22f1d76c.
The commits are the original ones from core at
00222c281f809f7460594cec2956daef91f3d8a2, with the same authors and sign-offs. The change is the paths, which follow this repository's layout (python/openshell/is nowsrc/openshell/, SDK tests are intests/), plus one hand-resolved conflict intests/e2e/conftest.py, where this repository's copy differs from core's (cluster_name: strhere). Thedelete_timeout_seconds=120.0andtimeout=120.0lines are the same as in core.These files are outside the SDK paths and stay in core:
docs/sdk/python.mdxThe documentation change stays in core (
docs/sdk/python.mdx).Merge with "Create a merge commit" or "Rebase and merge", not squash, so Eric Curtin stays the author.