Repository navigation
Conversation
Contributor
Author
|
Pulled in main, including #5196's fix for reusing table paths between tests. The full FlussSplitManagerTest class now passes locally (34 tests), along with all seven sketch tests on JDK 25. Pushed the update for CI to confirm. |
rahulbsw
marked this pull request as ready for review
November 13, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #3331. Add Trino SQL functions to build, merge, and query serialized Apache DataSketches HLL/KLL doubles sketches stored in Fluss.
Brief change log
fluss_functions in the connector plugin without replacing Trino's native sketch functions.Tests
FlussSplitManagerTestandSketchFunctionsTestpass together on JDK 25 (41 tests). The branch includes the upstream physical-table-path fix from [Trino] Temporarily isolate test table paths to unblock CI #5196; the Trino Connector CI job also passes.API and Format
Adds
fluss_hll_build_agg,fluss_hll_merge_agg,fluss_hll_estimate,fluss_kll_double_build_agg,fluss_kll_double_merge_agg, andfluss_kll_double_quantile. Final results use portable sketch bytes (HLL lgK 12, KLL k 200); intermediate state has an internal family marker. Readers return DOUBLE. KLL server-side merging requires #5121. Trino connector writes remain unsupported.Documentation
Adds SQL examples, Java compatibility details, and sketch semantics to the connector README.
Reviewed with sol-loop: 1 rounds with gpt-6.1-sol on high. Sol verdict: approved
Generative AI disclosure: Yes, OpenAI Codex.
Created with OpenAI Codex in the Codex app; pending maintainer review.