Repository navigation
[core] Read legacy schemas with Java-compatible defaults - #1388
Open
suxiaogang223 wants to merge 1 commit into
Open
suxiaogang223 wants to merge 1 commit into
suxiaogang223 wants to merge 1 commit into
Conversation
Fixes apache#1384. Apply legacy defaults at the shared serde boundary so historical schema files and resolved C table construction agree with Java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1384
Legacy Java schema JSON can omit
version. Rust currently rejects it, and accepting the JSON alone would still select the wrong bucket/file-format defaults for older schemas. Interpret stored schemas using the Java 2.1.0 version boundaries in the shared deserializer, covering filesystem history and catalog-free C construction.Brief change log
Tests
cargo +1.95.0 test --locked -p paimon --lib: 4,864 passed, 6 ignored.cargo +1.95.0 test --locked -p paimon-c --lib: 98 passed.cargo +1.95.0 fmt --all -- --checkandgit diff --check: passed.-D warnings -A clippy::nonminimal_bool. The unmodified expressions in vector-read/merge modules trigger sixnonminimal_boolerrors under strict Rust 1.95 Clippy; no lint suppressions were added to source.Local Cargo builds used debug info disabled and incremental compilation disabled. No new Java runtime fixture was executed; compatibility rules were checked against Java 2.1.0 SchemaSerializer.
API and Format
No public signatures or schema version numbers change. Legacy JSON receives version-dependent defaults during deserialization; current-version schemas and serialization retain their existing shape.
Documentation
The compatibility rule is documented beside the deserializer and in regression cases. No new configuration is needed.
AI assistance: Codex helped develop the implementation, tests, and this description.