Repository navigation
[core] Acquire REST commit leases only on retries - #11147
Draft
leaves12138 wants to merge 9 commits into
Draft
leaves12138 wants to merge 9 commits into
leaves12138 wants to merge 9 commits into
Conversation
leaves12138
marked this pull request as draft
November 13, 2026 12:47
leaves12138
marked this pull request as ready for review
November 13, 2026 16:09
leaves12138
marked this pull request as draft
November 13, 2026 17:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Rename
rest.commit.acquire-locktorest.commit.retry-acquire-lock. When enabled, the first REST publication attempt uses the catalog's expected-head check without acquiring a lease. A retry acquires the existing lease before checking the latest snapshot and preparing publication. The server capability still usesrest.commit.lock-enabled.Pass
firstCommitto the bound lock for ordinary commits, manifest compaction, and Data Evolution row-ID reassignment. Snapshot publication reuses the enclosing lock scope. Locks that require protection for filesystem publication continue to acquire it on every attempt.The explicit release endpoint and its client are covered by #11146. Both PRs target
masterand can merge independently.Verification
FileStoreCommitTestcases and the REST commit integration tests.