Repository navigation
Fix license headers and RAT exclusions for ATR's checks - #9263
Merged
Merged
Conversation
ATR matches the ASF license header word for word, which is stricter than RAT.
264 files failed it for three reasons:
- 169 files have a javadoc '<p>' or '<p/>' line inside the header. Those lines
now read ' *'. Wrapping and wording are untouched.
- 94 files carry the standard Apache-2.0 boilerplate, with or without a
'Copyright <year> The Apache Software Foundation.' line. They now use the ASF
template, as in storm-checkstyle's normalize-license-headers.groovy.
- 1 file has a typo ('ee the NOTICE file').
Only the leading comment changes. The two MIT-licensed cJSON files keep their
own header.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ATR runs Apache RAT on the release archives with its own defaults and reads exclusions only from a .rat-excludes file at the top of the archive, from the project's ATR settings, or from a URL. It does not read the apache-rat-plugin configuration in pom.xml, so docs, READMEs and the third-party license texts in licenses/ were reported as unknown or unapproved. The new file lists the same patterns as the rat profile of pom.xml, plus RELEASE and the generated public/dist assets of the binary distribution. It carries the ASF license header as '#' comments, so RAT accepts it without an exclusion. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
reiabreu
changed the title
Keeps .rat-excludes in sync with pom.xml for the ATR vote email template added in the RELEASING.md pull request. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
GGraziadei
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ATR checks on the 3.2.0 candidate flagged license headers and RAT results. This PR fixes both in the source tree. Only comments and one new file change.
1. License headers (ATR matches the ASF header word for word, which is stricter than RAT). 264 of 266 flagged files:
<p>or<p/>line inside the header. Those lines now read*. Wrapping and wording are unchanged.Copyright <year> The Apache Software Foundation.line. They now use the ASF template, as instorm-checkstyle/.../normalize-license-headers.groovy. 15 of them (dev-toolsscripts) had no copyright line at all.ee the NOTICE file, inLocalFsBlobStoreSynchronizer.java.cJSON.candcJSON.hfiles. They keep their own header.2. RAT (new
.rat-excludes). ATR runs RAT with its own defaults. It reads exclusions only from a.rat-excludesfile at the top of the archive, from the project's ATR settings, or from a URL, not frompom.xml. So docs, READMEs andlicenses/**were reported as unknown or unapproved. The new file lists the same patterns as theratprofile inpom.xml, plusRELEASEand**/public/dist/**for the binary distribution. It carries the ASF header as#comments.Verified:
pom.xmlconfig like ATR does: 171 flagged before, 0 with.rat-excludes. On the binary tarball: 40 before, 0 after, when the file sits at its root.mvn validate -P externals,examples,rat: 0 Checkstyle violations in 37 modules. Storm's own RAT passes with the new file.Limits:
v3.2.0tag..rat-excludes(the 3.2.0 archive already holds other root dotfiles), but I could not build the archive offline to confirm.🤖 Generated with Claude Code